Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: Source/web/WebFormElement.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebElementCollection.cpp ('k') | Source/web/WebNodeList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFormElement.cpp
diff --git a/Source/web/WebFormElement.cpp b/Source/web/WebFormElement.cpp
index 196b12c0463d997ea3bdb4c0f56ee8c162ee7a52..65a2bd67527408e93e2f2eae5688efc55f622026 100644
--- a/Source/web/WebFormElement.cpp
+++ b/Source/web/WebFormElement.cpp
@@ -78,19 +78,9 @@ void WebFormElement::submit()
void WebFormElement::getNamedElements(const WebString& name,
WebVector<WebNode>& result)
{
- Vector<RefPtr<Element> > tempVector;
+ WillBeHeapVector<RefPtrWillBeMember<Element> > tempVector;
unwrap<HTMLFormElement>()->getNamedElements(name, tempVector);
-#if ENABLE(OILPAN)
- // FIXME: The second argument of HTMLFormElement::getNamedElements should be
- // HeapVector<Member<Element>>.
- Vector<WebNode> tempVector2;
- tempVector2.reserveCapacity(tempVector.size());
- for (size_t i = 0; i < tempVector.size(); ++i)
- tempVector2.append(WebNode(tempVector[i].get()));
- result.assign(tempVector2);
-#else
result.assign(tempVector);
-#endif
}
void WebFormElement::getFormControlElements(WebVector<WebFormControlElement>& result) const
« no previous file with comments | « Source/web/WebElementCollection.cpp ('k') | Source/web/WebNodeList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698