Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: Source/core/html/HTMLTableSectionElement.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTableSectionElement.h ('k') | Source/core/html/LabelableElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTableSectionElement.cpp
diff --git a/Source/core/html/HTMLTableSectionElement.cpp b/Source/core/html/HTMLTableSectionElement.cpp
index eadd1a0f646b479a8b369cfb00453f723593660d..05207619e62485e3ec65dcfe36e34aca31d56535 100644
--- a/Source/core/html/HTMLTableSectionElement.cpp
+++ b/Source/core/html/HTMLTableSectionElement.cpp
@@ -65,7 +65,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableSectionElement::insertRow(Exception
// the index... but they aren't used during usual HTML parsing anyway
PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableSectionElement::insertRow(int index, ExceptionState& exceptionState)
{
- RefPtr<HTMLCollection> children = rows();
+ RefPtrWillBeRawPtr<HTMLCollection> children = rows();
int numRows = children ? static_cast<int>(children->length()) : 0;
if (index < -1 || index > numRows) {
exceptionState.throwDOMException(IndexSizeError, "The provided index (" + String::number(index) + " is outside the range [-1, " + String::number(numRows) + "].");
@@ -82,7 +82,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableSectionElement::insertRow(int index
void HTMLTableSectionElement::deleteRow(int index, ExceptionState& exceptionState)
{
- RefPtr<HTMLCollection> children = rows();
+ RefPtrWillBeRawPtr<HTMLCollection> children = rows();
int numRows = children ? (int)children->length() : 0;
if (index == -1)
index = numRows - 1;
@@ -102,7 +102,7 @@ int HTMLTableSectionElement::numRows() const
return rowCount;
}
-PassRefPtr<HTMLCollection> HTMLTableSectionElement::rows()
+PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableSectionElement::rows()
{
return ensureCachedHTMLCollection(TSectionRows);
}
« no previous file with comments | « Source/core/html/HTMLTableSectionElement.h ('k') | Source/core/html/LabelableElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698