Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: Source/core/html/HTMLTableRowElement.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTableRowElement.h ('k') | Source/core/html/HTMLTableRowsCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTableRowElement.cpp
diff --git a/Source/core/html/HTMLTableRowElement.cpp b/Source/core/html/HTMLTableRowElement.cpp
index 96888052440ad560686be88d6eeada98fdf517e5..9d5dea7280503bfeceb64b5a179b3ee5cf039fb6 100644
--- a/Source/core/html/HTMLTableRowElement.cpp
+++ b/Source/core/html/HTMLTableRowElement.cpp
@@ -127,7 +127,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableRowElement::insertCell(ExceptionSta
PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableRowElement::insertCell(int index, ExceptionState& exceptionState)
{
- RefPtr<HTMLCollection> children = cells();
+ RefPtrWillBeRawPtr<HTMLCollection> children = cells();
int numCells = children ? children->length() : 0;
if (index < -1 || index > numCells) {
exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(index) + ") is outside the range [-1, " + String::number(numCells) + "].");
@@ -144,7 +144,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> HTMLTableRowElement::insertCell(int index, E
void HTMLTableRowElement::deleteCell(int index, ExceptionState& exceptionState)
{
- RefPtr<HTMLCollection> children = cells();
+ RefPtrWillBeRawPtr<HTMLCollection> children = cells();
int numCells = children ? children->length() : 0;
if (index == -1)
index = numCells-1;
@@ -156,7 +156,7 @@ void HTMLTableRowElement::deleteCell(int index, ExceptionState& exceptionState)
}
}
-PassRefPtr<HTMLCollection> HTMLTableRowElement::cells()
+PassRefPtrWillBeRawPtr<HTMLCollection> HTMLTableRowElement::cells()
{
return ensureCachedHTMLCollection(TRCells);
}
« no previous file with comments | « Source/core/html/HTMLTableRowElement.h ('k') | Source/core/html/HTMLTableRowsCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698