Source/core/html/HTMLOptionsCollection.h - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionsCollection.h

diff --git a/Source/core/html/HTMLOptionsCollection.h b/Source/core/html/HTMLOptionsCollection.h

index 73adce94f74f580de487a56449dd02b3663be083..7afeda5386c696d847e497bb85f06ef809adfb20 100644

--- a/Source/core/html/HTMLOptionsCollection.h

+++ b/Source/core/html/HTMLOptionsCollection.h

@@ -34,7 +34,7 @@ class HTMLSelectElement;

class HTMLOptionsCollection FINAL : public HTMLCollection {

public:

- static PassRefPtr<HTMLOptionsCollection> create(ContainerNode&, CollectionType);

+ static PassRefPtrWillBeRawPtr<HTMLOptionsCollection> create(ContainerNode&, CollectionType);

void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&);

void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, int index, ExceptionState&);

@@ -45,7 +45,7 @@ public:

void setSelectedIndex(int);

void setLength(unsigned, ExceptionState&);

- void namedGetter(const AtomicString& name, bool&, RefPtr<NodeList>&, bool&, RefPtr<Element>&);

+ void namedGetter(const AtomicString& name, bool&, RefPtrWillBeRawPtr<NodeList>&, bool&, RefPtr<Element>&);

bool anonymousIndexedSetter(unsigned, PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&);

private:

« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | no next file with comments »