Source/core/dom/SelectorQuery.h - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SelectorQuery.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/SelectorQuery.h

diff --git a/Source/core/dom/SelectorQuery.h b/Source/core/dom/SelectorQuery.h

index 019632da5a87a90c0b6eb9063965d1ac44c6c498..25da2af2281b2d5a2ac39b925a5f547bddc64e1a 100644

--- a/Source/core/dom/SelectorQuery.h

+++ b/Source/core/dom/SelectorQuery.h

@@ -28,6 +28,7 @@

#define SelectorQuery_h

#include "core/css/CSSSelectorList.h"

+#include "platform/heap/Handle.h"

#include "wtf/HashMap.h"

#include "wtf/Vector.h"

#include "wtf/text/AtomicStringHash.h"

@@ -48,7 +49,7 @@ class SelectorDataList {

public:

void initialize(const CSSSelectorList&);

bool matches(Element&) const;

- PassRefPtr<NodeList> queryAll(ContainerNode& rootNode) const;

+ PassRefPtrWillBeRawPtr<NodeList> queryAll(ContainerNode& rootNode) const;

PassRefPtr<Element> queryFirst(ContainerNode& rootNode) const;

private:

@@ -89,7 +90,7 @@ class SelectorQuery {

public:

explicit SelectorQuery(const CSSSelectorList&);

bool matches(Element&) const;

- PassRefPtr<NodeList> queryAll(ContainerNode& rootNode) const;

+ PassRefPtrWillBeRawPtr<NodeList> queryAll(ContainerNode& rootNode) const;

PassRefPtr<Element> queryFirst(ContainerNode& rootNode) const;

private:

SelectorDataList m_selectors;

« no previous file with comments | « Source/core/dom/ParentNode.h ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »