Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: Source/core/dom/ChildNodeList.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ChildListMutationScope.cpp ('k') | Source/core/dom/ChildNodeList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ChildNodeList.h
diff --git a/Source/core/dom/ChildNodeList.h b/Source/core/dom/ChildNodeList.h
index a7dd03d699f4e201dadade1d7577513d224fe2e1..d3a871246cda2145bbfdd9171c5d4bf157071544 100644
--- a/Source/core/dom/ChildNodeList.h
+++ b/Source/core/dom/ChildNodeList.h
@@ -33,9 +33,9 @@ namespace WebCore {
class ChildNodeList FINAL : public NodeList {
public:
- static PassRefPtr<ChildNodeList> create(ContainerNode& rootNode)
+ static PassRefPtrWillBeRawPtr<ChildNodeList> create(ContainerNode& rootNode)
{
- return adoptRef(new ChildNodeList(rootNode));
+ return adoptRefWillBeNoop(new ChildNodeList(rootNode));
}
virtual ~ChildNodeList();
@@ -57,13 +57,15 @@ public:
Node* traverseForwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const;
Node* traverseBackwardToOffset(unsigned offset, Node& currentNode, unsigned& currentOffset) const;
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
explicit ChildNodeList(ContainerNode& rootNode);
virtual bool isChildNodeList() const OVERRIDE { return true; }
virtual Node* virtualOwnerNode() const OVERRIDE;
- RefPtr<ContainerNode> m_parent;
+ RefPtrWillBeMember<ContainerNode> m_parent;
mutable CollectionIndexCache<ChildNodeList, Node> m_collectionIndexCache;
};
« no previous file with comments | « Source/core/dom/ChildListMutationScope.cpp ('k') | Source/core/dom/ChildNodeList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698