Source/core/dom/Element.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make NodeListsNodeData::m_owner a strong ref Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index d0ecdf815c4a6f5086d6ea5c7f8d38e187946b7a..28886bc61dbeafb6eedc28a2c17311ea1ca09789 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2908,7 +2908,7 @@ void Element::updateExtraNamedItemRegistration(const AtomicString& oldId, const

toHTMLDocument(document()).addExtraNamedItem(newId);

}

-PassRefPtr<HTMLCollection> Element::ensureCachedHTMLCollection(CollectionType type)

+PassRefPtrWillBeRawPtr<HTMLCollection> Element::ensureCachedHTMLCollection(CollectionType type)

{

if (HTMLCollection* collection = cachedHTMLCollection(type))

return collection;

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Element.h ('k') | Source/core/dom/EmptyNodeList.h » ('j') | Source/core/dom/NodeRareData.cpp » ('J')