Oilpan: move LiveNodeList collections to the heap.

Source/core/html/HTMLAllCollection.cpp

 /*
  * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 13 matching lines @@
  */
 
 #include "config.h"
 #include "core/html/HTMLAllCollection.h"
 
 #include "core/dom/Element.h"
 #include "core/dom/NamedNodesCollection.h"
 
 namespace WebCore {
 
-PassRefPtr<HTMLAllCollection> HTMLAllCollection::create(ContainerNode& node, CollectionType type)
+PassRefPtrWillBeRawPtr<HTMLAllCollection> HTMLAllCollection::create(ContainerNode& node, CollectionType type)
 {
-    return adoptRef(new HTMLAllCollection(node, type));
+    return adoptRefWillBeNoop(new HTMLAllCollection(node, type));
 }
 
 HTMLAllCollection::HTMLAllCollection(ContainerNode& node, CollectionType type)
     : HTMLCollection(node, type, DoesNotOverrideItemAfter)
 {
     ScriptWrappable::init(this);
 }
 
 HTMLAllCollection::~HTMLAllCollection()
 {
 }
 
 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned index) const
 {
     updateIdNameCache();
 
     const NamedItemCache& cache = namedItemCache();
-    if (Vector<Element*>* elements = cache.getElementsById(name)) {
+    if (WillBeHeapVector<RawPtrWillBeMember<Element> >* elements = cache.getElementsById(name)) {
         if (index < elements->size())
             return elements->at(index);
         index -= elements->size();
     }
 
-    if (Vector<Element*>* elements = cache.getElementsByName(name)) {
+    if (WillBeHeapVector<RawPtrWillBeMember<Element> >* elements = cache.getElementsByName(name)) {
         if (index < elements->size())
             return elements->at(index);
     }
 
     return 0;
 }
 
-void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Element>& returnValue1)
+void HTMLAllCollection::namedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtrWillBeRawPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Element>& returnValue1)
 {
-    Vector<RefPtr<Element> > namedItems;
+    WillBeHeapVector<RefPtrWillBeMember<Element> > namedItems;
     this->namedItems(name, namedItems);
 
     if (!namedItems.size())
         return;
 
     if (namedItems.size() == 1) {
         returnValue1Enabled = true;
+#if ENABLE(OILPAN)
+        // FIXME: Oilpan: remove once Element becomes [GarbageCollected].
+        returnValue1 = PassRefPtr<Element>(namedItems.at(0).get());

[Mads Ager (chromium), 2014/05/15 10:54:24]

Does the following work in both builds?

// FIXME: Oilpan: Remove the call to |get| when Element becomes
[GarbageCollected].
returnValue1 = namedItems.at(0).get();

There are multiple occurrences if it does.

[sof, 2014/05/15 22:15:57]

It works to drop down to a bare pointer, the FIXME will help explain why it
looks unusual in a non-Oilpan light.

+#else
         returnValue1 = namedItems.at(0);
+#endif
         return;
     }
 
     // FIXME: HTML5 specification says this should be a HTMLCollection.
     // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
     returnValue0Enabled = true;
     returnValue0 = NamedNodesCollection::create(namedItems);
 }
 
 } // namespace WebCore