Oilpan: move LiveNodeList collections to the heap.

Source/core/html/CollectionIndexCache.h

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 20 matching lines @@
 
 #ifndef CollectionIndexCache_h
 #define CollectionIndexCache_h
 
 #include "core/dom/Element.h"
 
 namespace WebCore {
 
 template <typename Collection, typename NodeType>
 class CollectionIndexCache {
+    ALLOW_ONLY_INLINE_ALLOCATION();
 public:
     CollectionIndexCache();
 
     bool isEmpty(const Collection& collection)
     {
         if (isCachedNodeCountValid())
             return !cachedNodeCount();
         if (cachedNode())
             return false;
         return !nodeAt(collection, 0);
     }
     bool hasExactlyOneNode(const Collection& collection)
     {
         if (isCachedNodeCountValid())
             return cachedNodeCount() == 1;
         if (cachedNode())
             return !cachedNodeIndex() && !nodeAt(collection, 1);
         return nodeAt(collection, 0) && !nodeAt(collection, 1);
     }
 
     unsigned nodeCount(const Collection&);
     NodeType* nodeAt(const Collection&, unsigned index);
 
     void invalidate();
 
+    void traceAfterDispatch(Visitor* visitor)

[Mads Ager (chromium), 2014/05/15 10:54:24]

This is just a non-virtual trace method, so just call it trace and use
visitor->trace(collectionIndexCache) when you have one?

[sof, 2014/05/15 22:15:57]

Yes, now done + switched to DISALLOW_ALLOCATION() for this class.

+    {
+        visitor->trace(m_currentNode);
+    }
+
 private:
     NodeType* nodeBeforeCachedNode(const Collection&, unsigned index);
     NodeType* nodeAfterCachedNode(const Collection&, unsigned index);
 
     ALWAYS_INLINE NodeType* cachedNode() const { return m_currentNode; }
     ALWAYS_INLINE unsigned cachedNodeIndex() const { ASSERT(cachedNode()); return m_cachedNodeIndex; }
     ALWAYS_INLINE void setCachedNode(NodeType* node, unsigned index)
     {
         ASSERT(node);
         m_currentNode = node;
         m_cachedNodeIndex = index;
     }
 
     ALWAYS_INLINE bool isCachedNodeCountValid() const { return m_isLengthCacheValid; }
     ALWAYS_INLINE unsigned cachedNodeCount() const { return m_cachedNodeCount; }
     ALWAYS_INLINE void setCachedNodeCount(unsigned length)
     {
         m_cachedNodeCount = length;
         m_isLengthCacheValid = true;
     }
 
-    NodeType* m_currentNode;
+    RawPtrWillBeMember<NodeType> m_currentNode;
     unsigned m_cachedNodeCount;
     unsigned m_cachedNodeIndex;
     unsigned m_isLengthCacheValid : 1;
 };
 
 template <typename Collection, typename NodeType>
 CollectionIndexCache<Collection, NodeType>::CollectionIndexCache()
-    : m_currentNode(0)
+    : m_currentNode(nullptr)
     , m_cachedNodeCount(0)
     , m_cachedNodeIndex(0)
     , m_isLengthCacheValid(false)
 {
 }
 
 template <typename Collection, typename NodeType>
 void CollectionIndexCache<Collection, NodeType>::invalidate()
 {
-    m_currentNode = 0;
+    m_currentNode = nullptr;
     m_isLengthCacheValid = false;
 }
 
 template <typename Collection, typename NodeType>
 inline unsigned CollectionIndexCache<Collection, NodeType>::nodeCount(const Collection& collection)
 {
     if (isCachedNodeCountValid())
         return cachedNodeCount();
 
     nodeAt(collection, UINT_MAX);
@@ skipping 77 matching lines @@
         setCachedNodeCount(currentIndex + 1);
         return 0;
     }
     setCachedNode(currentNode, currentIndex);
     return currentNode;
 }
 
 } // namespace WebCore
 
 #endif // CollectionIndexCache_h