Oilpan: move LiveNodeList collections to the heap.

public/web/WebElementCollection.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 14 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebElementCollection_h
 #define WebElementCollection_h
 
-#include "../platform/WebCommon.h"
+#include "public/platform/WebCommon.h"

[tkent, 2014/05/13 11:20:37]

Please keep ../.  This change will break Chromium build.

[sof, 2014/05/15 09:23:24]

Reverted, but I notice there are both styles (i.e., relative paths and
"public/platform") of #includes of WebCommon.h and other headers in this
directory. (And I thought we wanted to move to the latter.)

+#include "public/platform/WebPrivatePtr.h"
 
 namespace WebCore { class HTMLCollection; }
 #if BLINK_IMPLEMENTATION
+#include "platform/heap/Handle.h"
 namespace WTF { template <typename T> class PassRefPtr; }
 #endif
 
 namespace blink {
 class WebElement;
 
 // Provides readonly access to some properties of a DOM node.
 class WebElementCollection {
 public:
     ~WebElementCollection() { reset(); }
 
-    WebElementCollection() : m_private(0), m_current(0) { }
-    WebElementCollection(const WebElementCollection& n) : m_private(0) { assign(n); }
+    WebElementCollection() : m_current(0) { }
+    WebElementCollection(const WebElementCollection& n) { assign(n); }
     WebElementCollection& operator=(const WebElementCollection& n)
     {
         assign(n);
         return *this;
     }
 
-    bool isNull() const { return !m_private; }
+    bool isNull() const { return m_private.isNull(); }

[haraken, 2014/05/12 12:04:13]

Nit: If we forget to make this change, do we hit a compile error? I'm afraid
that it's easy to forget to make this change.

[sof, 2014/05/12 12:24:36]

I seem to remember answering this question in some other CL some time ago :) I
do it be reflex by now, but it does fail to compile.

 
     BLINK_EXPORT void reset();
     BLINK_EXPORT void assign(const WebElementCollection&);
 
     BLINK_EXPORT unsigned length() const;
     BLINK_EXPORT WebElement nextItem() const;
     BLINK_EXPORT WebElement firstItem() const;
 
 #if BLINK_IMPLEMENTATION
-    WebElementCollection(const WTF::PassRefPtr<WebCore::HTMLCollection>&);
+    WebElementCollection(const PassRefPtrWillBeRawPtr<WebCore::HTMLCollection>&);
+    WebElementCollection& operator=(const PassRefPtrWillBeRawPtr<WebCore::HTMLCollection>&);
 #endif
 
 private:
-    void assign(WebCore::HTMLCollection*);
-    WebCore::HTMLCollection* m_private;
+    WebPrivatePtr<WebCore::HTMLCollection> m_private;
     mutable unsigned m_current;
 };
 
 } // namespace blink
 
 #endif