Oilpan: move LiveNodeList collections to the heap.

Source/web/WebFormElement.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 60 matching lines @@
 }
 
 void WebFormElement::submit()
 {
     unwrap<HTMLFormElement>()->submit();
 }
 
 void WebFormElement::getNamedElements(const WebString& name,
                                       WebVector<WebNode>& result)
 {
-    Vector<RefPtr<Element> > tempVector;
+    WillBeHeapVector<RefPtrWillBeMember<Element> > tempVector;
     unwrap<HTMLFormElement>()->getNamedElements(name, tempVector);
 #if ENABLE(OILPAN)
     // FIXME: The second argument of HTMLFormElement::getNamedElements should be

[tkent, 2014/05/13 11:20:37]

We can resolve this FIXME.

[sof, 2014/05/15 09:23:24]

Done, but the type conversions needed to be able to allow such a direct
assign()ment was a bit fiddly to get right.

Ended up adding a WebNode constructor for Oilpan to handle this, please let me
know what you think. The cleanest solution I was able to come up with.

(As the FIXME in the header file says, the reference arg could be given the more
precise type WebVector<WebElement>, but changing a public API is best done
separately.)

     // HeapVector<Member<Element>>.
     Vector<WebNode> tempVector2;
     tempVector2.reserveCapacity(tempVector.size());
     for (size_t i = 0; i < tempVector.size(); ++i)
         tempVector2.append(WebNode(tempVector[i].get()));
     result.assign(tempVector2);
 #else
     result.assign(tempVector);
 #endif
 }
@@ skipping 31 matching lines @@
     m_private = e;
     return *this;
 }
 
 WebFormElement::operator PassRefPtrWillBeRawPtr<HTMLFormElement>() const
 {
     return toHTMLFormElement(m_private.get());
 }
 
 } // namespace blink