Oilpan: move LiveNodeList collections to the heap.

Source/web/tests/TouchActionTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 113 matching lines @@
     void runTestOnTree(WebCore::ContainerNode* root, WebView*, TouchActionTrackingWebViewClient&);
 
     std::string m_baseURL;
     FrameTestHelpers::WebViewHelper m_webViewHelper;
 };
 
 void TouchActionTest::runTouchActionTest(std::string file)
 {
     TouchActionTrackingWebViewClient client;
 
+    // runTouchActionTest() loads a document in a frame, setting up a
+    // nested message loop. Should any Oilpan GC happen while it is in
+    // effect, the implicit assumption that we're outside any event
+    // loop (=> there being no pointers on the stack needing scanning)
+    // when that GC strikes will no longer hold.
+    //
+    // To ensure that the references on the stack are also traced, we
+    // turn them into persistent, stack allocated references. This
+    // workaround is sufficient to handle this artificial test
+    // scenario.
     WebView* webView = setupTest(file, client);
 
-    RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
+    RefPtrWillBePersistent<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
     runTestOnTree(document.get(), webView, client);
 
     m_webViewHelper.reset(); // Explicitly reset to break dependency on locally scoped client.
 }
 
 void TouchActionTest::runShadowDOMTest(std::string file)
 {
     TouchActionTrackingWebViewClient client;
 
     WebView* webView = setupTest(file, client);
 
     WebCore::TrackExceptionState es;
-    RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
-    RefPtr<WebCore::NodeList> hostNodes = document->querySelectorAll("[shadow-host]", es);
+
+    // Oilpan: see runTouchActionTest() comment why these are persistent references.
+    RefPtrWillBePersistent<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
+    RefPtrWillBePersistent<WebCore::NodeList> hostNodes = document->querySelectorAll("[shadow-host]", es);
     ASSERT_FALSE(es.hadException());
     ASSERT_GE(hostNodes->length(), 1u);
 
     for (unsigned index = 0; index < hostNodes->length(); index++) {
         WebCore::ShadowRoot* shadowRoot = WebCore::toElement(hostNodes->item(index))->shadowRoot();
         runTestOnTree(shadowRoot, webView, client);
     }
 
     // Projections show up in the main document.
     runTestOnTree(document.get(), webView, client);
@@ skipping 18 matching lines @@
     RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
     document->frame()->view()->setScrollOffset(WebCore::IntPoint(0, kScrollOffset));
 
     return webView;
 }
 
 void TouchActionTest::runTestOnTree(WebCore::ContainerNode* root, WebView* webView, TouchActionTrackingWebViewClient& client)
 {
     // Find all elements to test the touch-action of in the document.
     WebCore::TrackExceptionState es;
-    RefPtr<WebCore::NodeList> nodes = root->querySelectorAll("[expected-action]", es);
+
+    // Oilpan: see runTouchActionTest() comment why these are persistent references.
+    RefPtrWillBePersistent<WebCore::NodeList> nodes = root->querySelectorAll("[expected-action]", es);
     ASSERT_FALSE(es.hadException());
 
     for (unsigned index = 0; index < nodes->length(); index++) {
         WebCore::Element* element = toElement(nodes->item(index));
         element->scrollIntoViewIfNeeded();
         ASSERT_TRUE(nodes->item(index)->isElementNode());
 
         std::string failureContext("Test case: ");
         if (element->hasID()) {
             failureContext.append(element->getIdAttribute().ascii().data());
         } else if (element->firstChild()) {
             failureContext.append("\"");
             failureContext.append(element->firstChild()->textContent(false).stripWhiteSpace().ascii().data());
             failureContext.append("\"");
         } else {
             failureContext += "<missing ID>";
         }
 
         // Run each test three times at different positions in the element.
         // Note that we don't want the bounding box because our tests sometimes have elements with
         // multiple border boxes with other elements in between. Use the first border box (which
         // we can easily visualize in a browser for debugging).
-        RefPtrWillBeRawPtr<WebCore::ClientRectList> rects = element->getClientRects();
+        RefPtrWillBePersistent<WebCore::ClientRectList> rects = element->getClientRects();
         ASSERT_GE(rects->length(), 0u) << failureContext;
-        RefPtrWillBeRawPtr<WebCore::ClientRect> r = rects->item(0);
+        RefPtrWillBePersistent<WebCore::ClientRect> r = rects->item(0);
         WebCore::FloatRect clientFloatRect = WebCore::FloatRect(r->left(), r->top(), r->width(), r->height());
         WebCore::IntRect clientRect =  enclosedIntRect(clientFloatRect);
         for (int locIdx = 0; locIdx < 3; locIdx++) {
             WebCore::IntPoint clientPoint;
             std::stringstream contextStream;
             contextStream << failureContext << " (";
             switch (locIdx) {
             case 0:
                 clientPoint = clientRect.center();
                 contextStream << "center";
@@ skipping 104 matching lines @@
 {
     runShadowDOMTest("touch-action-shadow-dom.html");
 }
 
 TEST_F(TouchActionTest, Pan)
 {
     runTouchActionTest("touch-action-pan.html");
 }
 
 }