Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: Source/core/rendering/RenderTheme.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/svg/SVGSVGElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 865 matching lines...) Expand 10 before | Expand all | Expand 10 after
876 tickRect.setY(floor(rect.y() + rect.height() / 2.0 + sliderTickOffsetFro mTrackCenter() * zoomFactor)); 876 tickRect.setY(floor(rect.y() + rect.height() / 2.0 + sliderTickOffsetFro mTrackCenter() * zoomFactor));
877 tickRegionSideMargin = trackBounds.x() + (thumbSize.width() - tickSize.w idth() * zoomFactor) / 2.0; 877 tickRegionSideMargin = trackBounds.x() + (thumbSize.width() - tickSize.w idth() * zoomFactor) / 2.0;
878 tickRegionWidth = trackBounds.width() - thumbSize.width(); 878 tickRegionWidth = trackBounds.width() - thumbSize.width();
879 } else { 879 } else {
880 tickRect.setWidth(floor(tickSize.height() * zoomFactor)); 880 tickRect.setWidth(floor(tickSize.height() * zoomFactor));
881 tickRect.setHeight(floor(tickSize.width() * zoomFactor)); 881 tickRect.setHeight(floor(tickSize.width() * zoomFactor));
882 tickRect.setX(floor(rect.x() + rect.width() / 2.0 + sliderTickOffsetFrom TrackCenter() * zoomFactor)); 882 tickRect.setX(floor(rect.x() + rect.width() / 2.0 + sliderTickOffsetFrom TrackCenter() * zoomFactor));
883 tickRegionSideMargin = trackBounds.y() + (thumbSize.width() - tickSize.w idth() * zoomFactor) / 2.0; 883 tickRegionSideMargin = trackBounds.y() + (thumbSize.width() - tickSize.w idth() * zoomFactor) / 2.0;
884 tickRegionWidth = trackBounds.height() - thumbSize.width(); 884 tickRegionWidth = trackBounds.height() - thumbSize.width();
885 } 885 }
886 RefPtr<HTMLCollection> options = dataList->options(); 886 RefPtrWillBeRawPtr<HTMLCollection> options = dataList->options();
887 GraphicsContextStateSaver stateSaver(*paintInfo.context); 887 GraphicsContextStateSaver stateSaver(*paintInfo.context);
888 paintInfo.context->setFillColor(o->resolveColor(CSSPropertyColor)); 888 paintInfo.context->setFillColor(o->resolveColor(CSSPropertyColor));
889 for (unsigned i = 0; Element* element = options->item(i); i++) { 889 for (unsigned i = 0; Element* element = options->item(i); i++) {
890 ASSERT(isHTMLOptionElement(*element)); 890 ASSERT(isHTMLOptionElement(*element));
891 HTMLOptionElement& optionElement = toHTMLOptionElement(*element); 891 HTMLOptionElement& optionElement = toHTMLOptionElement(*element);
892 String value = optionElement.value(); 892 String value = optionElement.value();
893 if (!input->isValidValue(value)) 893 if (!input->isValidValue(value))
894 continue; 894 continue;
895 double parsedValue = parseToDoubleForNumberType(input->sanitizeValue(val ue)); 895 double parsedValue = parseToDoubleForNumberType(input->sanitizeValue(val ue));
896 double tickFraction = (parsedValue - min) / (max - min); 896 double tickFraction = (parsedValue - min) / (max - min);
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 1216
1217 // padding - not honored by WinIE, needs to be removed. 1217 // padding - not honored by WinIE, needs to be removed.
1218 style->resetPadding(); 1218 style->resetPadding();
1219 1219
1220 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 1220 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
1221 // for now, we will not honor it. 1221 // for now, we will not honor it.
1222 style->resetBorder(); 1222 style->resetBorder();
1223 } 1223 }
1224 1224
1225 } // namespace WebCore 1225 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/svg/SVGSVGElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698