Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: Source/core/html/forms/ColorInputType.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/RadioNodeList.cpp ('k') | Source/core/html/forms/RangeInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 bool ColorInputType::shouldShowSuggestions() const 228 bool ColorInputType::shouldShowSuggestions() const
229 { 229 {
230 return element().fastHasAttribute(listAttr); 230 return element().fastHasAttribute(listAttr);
231 } 231 }
232 232
233 Vector<ColorSuggestion> ColorInputType::suggestions() const 233 Vector<ColorSuggestion> ColorInputType::suggestions() const
234 { 234 {
235 Vector<ColorSuggestion> suggestions; 235 Vector<ColorSuggestion> suggestions;
236 HTMLDataListElement* dataList = element().dataList(); 236 HTMLDataListElement* dataList = element().dataList();
237 if (dataList) { 237 if (dataList) {
238 RefPtr<HTMLCollection> options = dataList->options(); 238 RefPtrWillBeRawPtr<HTMLCollection> options = dataList->options();
239 for (unsigned i = 0; HTMLOptionElement* option = toHTMLOptionElement(opt ions->item(i)); i++) { 239 for (unsigned i = 0; HTMLOptionElement* option = toHTMLOptionElement(opt ions->item(i)); i++) {
240 if (!element().isValidValue(option->value())) 240 if (!element().isValidValue(option->value()))
241 continue; 241 continue;
242 Color color; 242 Color color;
243 if (!color.setFromString(option->value())) 243 if (!color.setFromString(option->value()))
244 continue; 244 continue;
245 ColorSuggestion suggestion(color, option->label().left(maxSuggestion LabelLength)); 245 ColorSuggestion suggestion(color, option->label().left(maxSuggestion LabelLength));
246 suggestions.append(suggestion); 246 suggestions.append(suggestion);
247 if (suggestions.size() >= maxSuggestions) 247 if (suggestions.size() >= maxSuggestions)
248 break; 248 break;
249 } 249 }
250 } 250 }
251 return suggestions; 251 return suggestions;
252 } 252 }
253 253
254 } // namespace WebCore 254 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/RadioNodeList.cpp ('k') | Source/core/html/forms/RangeInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698