Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/html/HTMLTableElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 return !usesMenuList(); 366 return !usesMenuList();
367 } 367 }
368 368
369 RenderObject* HTMLSelectElement::createRenderer(RenderStyle*) 369 RenderObject* HTMLSelectElement::createRenderer(RenderStyle*)
370 { 370 {
371 if (usesMenuList()) 371 if (usesMenuList())
372 return new RenderMenuList(this); 372 return new RenderMenuList(this);
373 return new RenderListBox(this); 373 return new RenderListBox(this);
374 } 374 }
375 375
376 PassRefPtr<HTMLCollection> HTMLSelectElement::selectedOptions() 376 PassRefPtrWillBeRawPtr<HTMLCollection> HTMLSelectElement::selectedOptions()
377 { 377 {
378 updateListItemSelectedStates(); 378 updateListItemSelectedStates();
379 return ensureCachedHTMLCollection(SelectedOptions); 379 return ensureCachedHTMLCollection(SelectedOptions);
380 } 380 }
381 381
382 PassRefPtr<HTMLOptionsCollection> HTMLSelectElement::options() 382 PassRefPtrWillBeRawPtr<HTMLOptionsCollection> HTMLSelectElement::options()
383 { 383 {
384 return static_cast<HTMLOptionsCollection*>(ensureCachedHTMLCollection(Select Options).get()); 384 return static_cast<HTMLOptionsCollection*>(ensureCachedHTMLCollection(Select Options).get());
385 } 385 }
386 386
387 void HTMLSelectElement::updateListItemSelectedStates() 387 void HTMLSelectElement::updateListItemSelectedStates()
388 { 388 {
389 if (!m_shouldRecalcListItems) 389 if (!m_shouldRecalcListItems)
390 return; 390 return;
391 recalcListItems(); 391 recalcListItems();
392 setNeedsValidityCheck(); 392 setNeedsValidityCheck();
(...skipping 1265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1658 1658
1659 void HTMLSelectElement::trace(Visitor* visitor) 1659 void HTMLSelectElement::trace(Visitor* visitor)
1660 { 1660 {
1661 #if ENABLE(OILPAN) 1661 #if ENABLE(OILPAN)
1662 visitor->trace(m_listItems); 1662 visitor->trace(m_listItems);
1663 #endif 1663 #endif
1664 HTMLFormControlElementWithState::trace(visitor); 1664 HTMLFormControlElementWithState::trace(visitor);
1665 } 1665 }
1666 1666
1667 } // namespace 1667 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/html/HTMLTableElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698