Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 #include "bindings/v8/V8Binding.h" 36 #include "bindings/v8/V8Binding.h"
37 #include "core/dom/NamedNodesCollection.h" 37 #include "core/dom/NamedNodesCollection.h"
38 #include "core/html/HTMLAllCollection.h" 38 #include "core/html/HTMLAllCollection.h"
39 #include "core/frame/UseCounter.h" 39 #include "core/frame/UseCounter.h"
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 template<class CallbackInfo> 43 template<class CallbackInfo>
44 static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic String name, const CallbackInfo& info) 44 static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic String name, const CallbackInfo& info)
45 { 45 {
46 Vector<RefPtr<Element> > namedItems; 46 WillBeHeapVector<RefPtrWillBeMember<Element> > namedItems;
47 collection->namedItems(name, namedItems); 47 collection->namedItems(name, namedItems);
48 48
49 if (!namedItems.size()) 49 if (!namedItems.size())
50 return v8Undefined(); 50 return v8Undefined();
51 51
52 if (namedItems.size() == 1) 52 if (namedItems.size() == 1)
53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() ); 53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() );
54 54
55 // FIXME: HTML5 specification says this should be a HTMLCollection. 55 // FIXME: HTML5 specification says this should be a HTMLCollection.
56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 if (index.IsEmpty()) 102 if (index.IsEmpty())
103 return; 103 return;
104 104
105 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) { 105 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) {
106 v8SetReturnValueFast(info, node, impl); 106 v8SetReturnValueFast(info, node, impl);
107 return; 107 return;
108 } 108 }
109 } 109 }
110 110
111 } // namespace WebCore 111 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698