Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 2801213002: Output warning when the container window doesn't exist unexpectedly (Closed)
Patch Set: Used DCHECK only and commented retionale why the windw should have been created. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller.cc
diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc
index e0912a72d1b8c9fdec50c2ded0d21086bd688b3e..5e1680d60722949359f3642c720c14bdacda3386 100644
--- a/ui/keyboard/keyboard_controller.cc
+++ b/ui/keyboard/keyboard_controller.cc
@@ -410,8 +410,9 @@ void KeyboardController::OnShowImeIfNeeded() {
}
void KeyboardController::ShowKeyboardInternal(int64_t display_id) {
- if (!container_.get())
- return;
+ // The container window should have been created already when
+ // |Shell::CreateKeyboard| is called.
+ DCHECK(container_.get());
if (container_->children().empty()) {
keyboard::MarkKeyboardLoadStarted();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698