Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js

Issue 2801193002: [Polymer] update paper-slider for RTL support (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js b/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js
index b555b0a43bafe40f50066bbb8433abcbbdea2b7f..d5f02d65894c7aa3cc3eaf9becb9db13aad14837 100644
--- a/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js
@@ -114,8 +114,10 @@ Polymer({
},
keyBindings: {
- 'left down pagedown home': '_decrementKey',
- 'right up pageup end': '_incrementKey'
+ 'left': '_leftKey',
+ 'right': '_rightKey',
+ 'down pagedown home': '_decrementKey',
+ 'up pageup end': '_incrementKey'
},
/**
@@ -213,7 +215,9 @@ Polymer({
this._trackStart(event);
}
- var dx = Math.min(this._maxx, Math.max(this._minx, event.detail.dx));
+ var direction = this._isRTL ? -1 : 1;
+ var dx = Math.min(
+ this._maxx, Math.max(this._minx, event.detail.dx * direction));
this._x = this._startx + dx;
var immediateValue = this._calcStep(this._calcKnobPosition(this._x / this._w));
@@ -251,6 +255,9 @@ Polymer({
this._w = this.$.sliderBar.offsetWidth;
var rect = this.$.sliderBar.getBoundingClientRect();
var ratio = (event.detail.x - rect.left) / this._w;
+ if (this._isRTL) {
+ ratio = 1 - ratio;
+ }
var prevRatio = this.ratio;
this._setTransiting(true);
@@ -292,6 +299,9 @@ Polymer({
if (steps > maxMarkers) {
steps = maxMarkers;
}
+ if (steps < 0 || !isFinite(steps)) {
+ steps = 0;
+ }
dschuyler 2017/04/07 02:59:59 This is a change that wasn't in my PR, but it look
this._setMarkers(new Array(steps));
},
@@ -315,6 +325,27 @@ Polymer({
});
},
+ get _isRTL() {
+ if (this.__isRTL === undefined) {
+ this.__isRTL = window.getComputedStyle(this)['direction'] === 'rtl';
+ }
+ return this.__isRTL;
+ },
+
+ _leftKey: function(event) {
+ if (this._isRTL)
+ this._incrementKey(event);
+ else
+ this._decrementKey(event);
+ },
+
+ _rightKey: function(event) {
+ if (this._isRTL)
+ this._decrementKey(event);
+ else
+ this._incrementKey(event);
+ },
+
_incrementKey: function(event) {
if (!this.disabled) {
if (event.detail.key === 'end') {

Powered by Google App Engine
This is Rietveld 408576698