Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2801183002: [WASM SIMD] Implement primitive shuffles. (Closed)
Patch Set: Add comments, remove S64x2Reverse, as it's redundant. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index fba2fa46d3c6bcf204ac7ebe12aa81ed83527029..2941efa8c1a3ae923440ca4eac7161b158cf69ac 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -3444,15 +3444,81 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
inputs[1]);
case wasm::kExprS128Not:
return graph()->NewNode(jsgraph()->machine()->S128Not(), inputs[0]);
+ case wasm::kExprS32x4ZipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S32x4ZipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS32x4ZipRight:
+ return graph()->NewNode(jsgraph()->machine()->S32x4ZipRight(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS32x4UnzipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S32x4UnzipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS32x4UnzipRight:
+ return graph()->NewNode(jsgraph()->machine()->S32x4UnzipRight(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS32x4TransposeLeft:
+ return graph()->NewNode(jsgraph()->machine()->S32x4TransposeLeft(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS32x4TransposeRight:
+ return graph()->NewNode(jsgraph()->machine()->S32x4TransposeRight(),
+ inputs[0], inputs[1]);
case wasm::kExprS32x4Select:
return graph()->NewNode(jsgraph()->machine()->S32x4Select(), inputs[0],
inputs[1], inputs[2]);
+ case wasm::kExprS16x8ZipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S16x8ZipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS16x8ZipRight:
+ return graph()->NewNode(jsgraph()->machine()->S16x8ZipRight(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS16x8UnzipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S16x8UnzipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS16x8UnzipRight:
+ return graph()->NewNode(jsgraph()->machine()->S16x8UnzipRight(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS16x8TransposeLeft:
+ return graph()->NewNode(jsgraph()->machine()->S16x8TransposeLeft(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS16x8TransposeRight:
+ return graph()->NewNode(jsgraph()->machine()->S16x8TransposeRight(),
+ inputs[0], inputs[1]);
case wasm::kExprS16x8Select:
return graph()->NewNode(jsgraph()->machine()->S16x8Select(), inputs[0],
inputs[1], inputs[2]);
+ case wasm::kExprS8x16ZipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S8x16ZipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS8x16ZipRight:
+ return graph()->NewNode(jsgraph()->machine()->S8x16ZipRight(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS8x16UnzipLeft:
+ return graph()->NewNode(jsgraph()->machine()->S8x16UnzipLeft(), inputs[0],
+ inputs[1]);
+ case wasm::kExprS8x16UnzipRight:
+ return graph()->NewNode(jsgraph()->machine()->S8x16UnzipRight(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS8x16TransposeLeft:
+ return graph()->NewNode(jsgraph()->machine()->S8x16TransposeLeft(),
+ inputs[0], inputs[1]);
+ case wasm::kExprS8x16TransposeRight:
+ return graph()->NewNode(jsgraph()->machine()->S8x16TransposeRight(),
+ inputs[0], inputs[1]);
case wasm::kExprS8x16Select:
return graph()->NewNode(jsgraph()->machine()->S8x16Select(), inputs[0],
inputs[1], inputs[2]);
+ case wasm::kExprS32x2Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S32x2Reverse(), inputs[0]);
+ case wasm::kExprS16x4Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S16x4Reverse(), inputs[0]);
+ case wasm::kExprS16x2Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S16x2Reverse(), inputs[0]);
+ case wasm::kExprS8x8Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S8x8Reverse(), inputs[0]);
+ case wasm::kExprS8x4Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S8x4Reverse(), inputs[0]);
+ case wasm::kExprS8x2Reverse:
+ return graph()->NewNode(jsgraph()->machine()->S8x2Reverse(), inputs[0]);
case wasm::kExprS1x4And:
return graph()->NewNode(jsgraph()->machine()->S1x4And(), inputs[0],
inputs[1]);
@@ -3569,22 +3635,10 @@ Node* WasmGraphBuilder::SimdShiftOp(wasm::WasmOpcode opcode, uint8_t shift,
}
}
-Node* WasmGraphBuilder::SimdSwizzleOp(wasm::WasmOpcode opcode, uint32_t swizzle,
- const NodeVector& inputs) {
+Node* WasmGraphBuilder::SimdConcatOp(uint8_t bytes, const NodeVector& inputs) {
has_simd_ = true;
- switch (opcode) {
- case wasm::kExprS32x4Swizzle:
- return graph()->NewNode(jsgraph()->machine()->S32x4Swizzle(swizzle),
- inputs[0]);
- case wasm::kExprS16x8Swizzle:
- return graph()->NewNode(jsgraph()->machine()->S16x8Swizzle(swizzle),
- inputs[0]);
- case wasm::kExprS8x16Swizzle:
- return graph()->NewNode(jsgraph()->machine()->S8x16Swizzle(swizzle),
- inputs[0]);
- default:
- return graph()->NewNode(UnsupportedOpcode(opcode), nullptr);
- }
+ return graph()->NewNode(jsgraph()->machine()->S8x16Concat(bytes), inputs[0],
+ inputs[1]);
}
static void RecordFunctionCompilation(CodeEventListener::LogEventsAndTags tag,

Powered by Google App Engine
This is Rietveld 408576698