arc: Provide API to control Play Store state from autotests

chrome/common/extensions/api/autotest_private.idl

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // API for integration testing. To be used on test images with a test component
 // extension.
 namespace autotestPrivate {
 
   dictionary LoginStatusDict {
     // Are we logged in?
@@ skipping 44 matching lines @@
 
   dictionary Notification {
     DOMString id;
     DOMString type;
     DOMString title;
     DOMString message;
     long priority;
     long progress;
   };
   callback NotificationArrayCallback = void (Notification[] notifications);
+  callback EnabledCallback = void (boolean enabled);

[Devlin, 2017/04/10 21:53:54]

nit: just use one:
callback BooleanCallback = void(boolean result)

[khmel, 2017/04/11 21:16:28]

Done.

+  callback ManagedCallback = void (boolean managed);
 
   interface Functions {
     // Logout of a user session.
     static void logout();
 
     // Restart the browser.
     static void restart();
 
     // Shutdown the browser.
     // |force|: if set, ignore ongoing downloads and onunbeforeunload handlers.
@@ skipping 34 matching lines @@
     // Set the mouse pointer sensitivity setting.
     // |value|: the pointer sensitivity setting index.
     static void setMouseSensitivity(long value);
 
     // Swap the primary mouse button for left click.
     // |right|: if set, swap the primary mouse button.
     static void setPrimaryButtonRight(boolean right);
 
     // Get visible notifications on the system.
     static void getVisibleNotifications(NotificationArrayCallback callback);
+
+    // Return true if Play Store is currently enabled on device.

[Devlin, 2017/04/10 21:53:54]

Function comments should be descriptive, not imperative.  Also, should be `if
*the* Play Store is currently enabled on *the* device`. (emphasis just to call
out differences)

[khmel, 2017/04/11 21:16:28]

Tried to rephrase.

+    static void isPlayStoreEnabled(EnabledCallback callback);
+
+    // Return true in callback if Play Store is managed by policy.
+    static void isPlayStoreManaged(ManagedCallback callback);

[stevenjb, 2017/04/11 15:58:56]

Do we anticipate any additional play store related state that might be useful in
an auto test? It might be better to create a sing getPlayStoreState function
that returns a dictionary with 'enabled' and 'managed'. Then if we need
additional state later we could easily add it. (That said, I can't think of what
else we might care about... maybe settings_app_installed?)

[khmel, 2017/04/11 21:16:28]

I think this is not very applicable for current situation. If we follow this
approach we have to return enabled, disabled, enabled_managed, disabled_managed
and probably not_avaialable. It seems this complicates implementation and is in
contradiction how we use this internally. These js functions just map internal
implementation.

[stevenjb, 2017/04/11 21:36:05]

I meant that we can return a dictionary:

dictionary PlayStoreState {
  boolean enabled;
  boolean managed;
  boolean available;
  boolean settings_app_installed;
}

static void getPlayStoreState(GetPlayStoreState callback);

[khmel, 2017/04/13 00:15:30]

Sorry, did not get you that time. Yes, this sounds better. Done except
settings_app_installed which is currently not needed.

+
+    // Enable or disable Play Store on device. Return true in callback if Play

[Devlin, 2017/04/10 21:53:54]

This seems like the result is basically just whether or not the call succeeded. 
If the call didn't succeed, we should probably return an error instead.

[stevenjb, 2017/04/11 15:58:56]

Agreed. Specifically, make this a void callback and set an error on failure.

[khmel, 2017/04/11 21:16:28]

Good points, thanks

+    // Store was enabled.
+    static void setPlayStoreEnabled(boolean enabled, EnabledCallback callback);
   };
 };