arc: Provide API to control Play Store state from autotests

chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/autotest_private/autotest_private_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/lazy_instance.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/autotest_private.h"
 #include "extensions/browser/extension_function_registry.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/options_page_info.h"
 #include "extensions/common/permissions/api_permission_set.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 #if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
 #include "chrome/browser/chromeos/system/input_device_settings.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "components/user_manager/user.h"
 #include "components/user_manager/user_manager.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification.h"
 #endif
 
 namespace extensions {
 namespace {
@@ skipping 329 matching lines @@
     result->SetString("message", notification->message());
     result->SetInteger("priority", notification->priority());
     result->SetInteger("progress", notification->progress());
     values->Append(std::move(result));
   }
 
 #endif
   return RespondNow(OneArgument(std::move(values)));
 }
 
+ExtensionFunction::ResponseAction
+AutotestPrivateIsPlayStoreEnabledFunction::Run() {
+  DVLOG(1) << "AutotestPrivateIsPlayStoreEnabledFunction";
+  bool enabled = false;
+#if defined(OS_CHROMEOS)
+  Profile* profile = ProfileManager::GetActiveUserProfile();

[Luis Héctor Chávez, 2017/04/07 01:57:50]

qq: is Profile* guaranteed to be non-null at this point always?

[khmel, 2017/04/07 15:52:45]

I think no, but arc::IsArcAllowedForProfile(profile) handles null profiles

+  enabled = arc::IsArcAllowedForProfile(profile) &&

[Luis Héctor Chávez, 2017/04/07 01:57:50]

nit: This is redundant.

[khmel, 2017/04/07 15:52:45]

Removed.

+            arc::IsArcPlayStoreEnabledForProfile(profile);
+#endif
+  return RespondNow(OneArgument(base::MakeUnique<base::Value>(enabled)));
+}
+
+ExtensionFunction::ResponseAction
+AutotestPrivateIsPlayStoreManagedFunction::Run() {
+  DVLOG(1) << "AutotestPrivateIsPlayStoreManagedFunction";
+  bool managed = false;
+#if defined(OS_CHROMEOS)
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  managed = arc::IsArcAllowedForProfile(profile) &&
+            arc::IsArcPlayStoreEnabledPreferenceManagedForProfile(profile);
+#endif
+  return RespondNow(OneArgument(base::MakeUnique<base::Value>(managed)));
+}
+
+ExtensionFunction::ResponseAction
+AutotestPrivateSetPlayStoreEnabledFunction::Run() {
+  DVLOG(1) << "AutotestPrivateSetPlayStoreEnabledFunction";
+  std::unique_ptr<api::autotest_private::SetPlayStoreEnabled::Params> params(
+      api::autotest_private::SetPlayStoreEnabled::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+#if defined(OS_CHROMEOS)
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  if (arc::IsArcAllowedForProfile(profile))

[Luis Héctor Chávez, 2017/04/07 02:01:53]

Do you also want the semantics of this actually enabling the play store even if
the setting is managed? Can people on their Chromebooks use this API to
circumvent policy?

[khmel, 2017/04/07 15:52:45]

This is good point. I will update arc::SetArcPlayStoreEnabledForProfile

+    arc::SetArcPlayStoreEnabledForProfile(profile, params->enabled);
+#endif
+  return RespondNow(NoArguments());

[Luis Héctor Chávez, 2017/04/07 01:57:50]

Don't you want to return success/failure? Otherwise document this is a no-op if
autotestPrivate.isPlayStoreEnabled() returns false.

[khmel, 2017/04/07 15:52:45]

Added returning the value

+}
+
 static base::LazyInstance<BrowserContextKeyedAPIFactory<AutotestPrivateAPI>>::
     DestructorAtExit g_factory = LAZY_INSTANCE_INITIALIZER;
 
 // static
 BrowserContextKeyedAPIFactory<AutotestPrivateAPI>*
 AutotestPrivateAPI::GetFactoryInstance() {
   return g_factory.Pointer();
 }
 
 template <>
 KeyedService*
 BrowserContextKeyedAPIFactory<AutotestPrivateAPI>::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   return new AutotestPrivateAPI();
 }
 
 AutotestPrivateAPI::AutotestPrivateAPI() : test_mode_(false) {
 }
 
 AutotestPrivateAPI::~AutotestPrivateAPI() {
 }
 
 }  // namespace extensions