arc: Provide API to control Play Store state from autotests

chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/autotest_private/autotest_private_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 10 matching lines @@
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_util.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/options_page_info.h"
 #include "extensions/common/permissions/api_permission_set.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 #if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
 #include "chrome/browser/chromeos/system/input_device_settings.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "components/user_manager/user.h"
 #include "components/user_manager/user_manager.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification.h"
 #endif
 
 namespace extensions {
 namespace {
@@ skipping 330 matching lines @@
     result->SetString("message", notification->message());
     result->SetInteger("priority", notification->priority());
     result->SetInteger("progress", notification->progress());
     values->Append(std::move(result));
   }
 
 #endif
   return RespondNow(OneArgument(std::move(values)));
 }
 
+ExtensionFunction::ResponseAction
+AutotestPrivateGetPlayStoreStateFunction::Run() {
+  DVLOG(1) << "AutotestPrivateGetPlayStoreStateFunction";

[Devlin, 2017/04/13 21:49:52]

Do you need to keep these logs?

[khmel, 2017/04/13 23:02:51]

Most of the functions here use similar structure: for example L 366

+  std::unique_ptr<base::DictionaryValue> play_store_state_value =
+      base::MakeUnique<base::DictionaryValue>();
+  play_store_state_value->SetBoolean("allowed", false);
+#if defined(OS_CHROMEOS)
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  if (arc::IsArcAllowedForProfile(profile)) {
+    play_store_state_value->SetBoolean("allowed", true);

[Devlin, 2017/04/13 21:49:52]

Please use the generated types rather than using a custom-built value.

[khmel, 2017/04/13 23:02:51]

Done.

+    play_store_state_value->SetBoolean(
+        "enabled", arc::IsArcPlayStoreEnabledForProfile(profile));
+    play_store_state_value->SetBoolean(
+        "managed",
+        arc::IsArcPlayStoreEnabledPreferenceManagedForProfile(profile));
+  }
+#endif
+  return RespondNow(OneArgument(std::move(play_store_state_value)));
+}
+
+ExtensionFunction::ResponseAction
+AutotestPrivateSetPlayStoreEnabledFunction::Run() {
+  DVLOG(1) << "AutotestPrivateSetPlayStoreEnabledFunction";
+  std::unique_ptr<api::autotest_private::SetPlayStoreEnabled::Params> params(
+      api::autotest_private::SetPlayStoreEnabled::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+#if defined(OS_CHROMEOS)
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  if (arc::IsArcAllowedForProfile(profile)) {
+    arc::SetArcPlayStoreEnabledForProfile(profile, params->enabled);
+    if (params->enabled != arc::IsArcPlayStoreEnabledForProfile(profile)) {

[Devlin, 2017/04/13 21:49:52]

This would be cleaner if we just had SetArcPlayStoreEnabledForProfile() return a
boolean indicating success.

[khmel, 2017/04/13 23:02:51]

You mean static boolean SetArcPlayStoreEnabledForProfile() ?

I tried this in my implementation. When I do like this I cannot use
SetArcPlayStoreEnabledForProfile in test.js because I always getting error:

[FAIL] setPlayStoreEnabled: uncaught exception: Parameter 1
(setPlayStoreEnabled) is required.: Error: Parameter 1 (setPlayStoreEnabled) is
required.

for 
    chrome.autotestPrivate.setPlayStoreEnabled(false);
    chrome.test.succeed();

I also did not find good example that has inline boolean as return type.

PS. In your previous comment you suggested to return error:

[Devlin, 2017/04/13 23:06:00]

Ah, sorry, I can see how that would be confusing.  I mean changing the signature
of arc::SetArcPlayStoreEnabledForProfile() defined in arc_util.cc.  If that
could return a boolean indicating whether or not the set was successful, we
wouldn't have to then check the state here.  i.e., this becomes:

if (!arc::SetArcPlayStoreEnabledForProfile(profile, params->enabled)) {
  Respond(Error("ARC state cannot be changed for the current user"));
}

[khmel, 2017/04/13 23:16:01]

Got you :), done.

+      return RespondNow(
+          Error("ARC enabled state cannot be changed for the current user"));
+    }
+    return RespondNow(NoArguments());
+  } else {
+    return RespondNow(Error("ARC is not available for the current user"));
+  }
+#endif
+  return RespondNow(Error("ARC is not available for the current platform"));
+}
+
 static base::LazyInstance<BrowserContextKeyedAPIFactory<AutotestPrivateAPI>>::
     DestructorAtExit g_factory = LAZY_INSTANCE_INITIALIZER;
 
 // static
 BrowserContextKeyedAPIFactory<AutotestPrivateAPI>*
 AutotestPrivateAPI::GetFactoryInstance() {
   return g_factory.Pointer();
 }
 
 template <>
 KeyedService*
 BrowserContextKeyedAPIFactory<AutotestPrivateAPI>::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   return new AutotestPrivateAPI();
 }
 
 AutotestPrivateAPI::AutotestPrivateAPI() : test_mode_(false) {
 }
 
 AutotestPrivateAPI::~AutotestPrivateAPI() {
 }
 
 }  // namespace extensions