Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2801143003: Remove the "pkgbuild" step on the bots. (Closed)

Created:
3 years, 8 months ago by Bob Nystrom
Modified:
3 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, dgrove
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the "pkgbuild" step on the bots. Those tests are flaky since they fail when AppEngine flakes out. Even when they work, they don't provide much value. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/5a035357663c6e0f43bd4a7c28706dde34b72d34

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -215 lines) Patch
D pkg/pkgbuild.status View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/bots/pkg.py View 2 chunks +0 lines, -10 lines 0 comments Download
M tools/gardening/lib/src/buildbot_data.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/status_clean.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/package_testing_support.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +0 lines, -172 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
This test configuration doesn't seem to be giving us any real value, so instead of ...
3 years, 8 months ago (2017-04-06 21:33:21 UTC) #2
Bob Nystrom
Friendly ping now that I'm back from vacation.
3 years, 8 months ago (2017-04-21 22:07:04 UTC) #3
Bill Hesse
lgtm
3 years, 8 months ago (2017-04-24 15:56:51 UTC) #4
Bob Nystrom
3 years, 8 months ago (2017-04-24 20:28:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5a035357663c6e0f43bd4a7c28706dde34b72d34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698