Issue 280113002: Revert of Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data.

Issue 280113002: Revert of Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. (Closed)

Created:
6 years, 7 months ago by Alpha Left Google

Modified:
6 years, 7 months ago

Reviewers:
erikwright (departed), Nicolas Zea, engedy, jochen (gone - plz use gerrit), Peter Kasting

CC:
chromium-reviews, Cait (Slow), gab, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. (https://codereview.chromium.org/268643002/) Reason for revert: Unfortunately I have to revert this change because this is in the way of reverting https://codereview.chromium.org/270533007/. The above change is causing some use after free failures on Mac. Please see this: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759/steps/unit_tests/logs/stdio Original issue's description: > Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. > > BUG=365762 > R=engedy@chromium.org, jochen@chromium.org, pkasting@chromium.org, zea@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269396 TBR=pkasting@chromium.org,zea@chromium.org,engedy@chromium.org,jochen@chromium.org,erikwright@chromium.org NOTREECHECKS=true NOTRY=true BUG=365762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269635

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1074 lines, -648 lines)			Patch
M	chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc	View	1 chunk	+15 lines, -27 lines	0 comments	Download
M	chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc	View	5 chunks	+31 lines, -11 lines	0 comments	Download
M	chrome/browser/search_engines/default_search_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/search_engines/default_search_pref_migration.cc	View	3 chunks	+2 lines, -21 lines	0 comments	Download
M	chrome/browser/search_engines/default_search_pref_migration_unittest.cc	View	7 chunks	+89 lines, -74 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.h	View	13 chunks	+73 lines, -59 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.cc	View	39 chunks	+604 lines, -334 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_sync_unittest.cc	View	4 chunks	+35 lines, -24 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_test_util.cc	View	2 chunks	+39 lines, -42 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_unittest.cc	View	7 chunks	+140 lines, -23 lines	0 comments	Download
M	chrome/browser/search_engines/util.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/search_engines/util.cc	View	10 chunks	+31 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

Created Revert of Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data.

6 years, 7 months ago (2014-05-10 20:37:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/280113002/1

6 years, 7 months ago (2014-05-10 20:40:31 UTC) #2

Message was sent while issue was closed.

Change committed as 269635

Expand Messages | Collapse Messages