Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/debug/debug.cc

Issue 2801073006: Decouple root visitors from object visitors. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/frames.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 410
411 411
412 char* Debug::RestoreDebug(char* storage) { 412 char* Debug::RestoreDebug(char* storage) {
413 // Simply reset state. Don't restore anything. 413 // Simply reset state. Don't restore anything.
414 ThreadInit(); 414 ThreadInit();
415 return storage + ArchiveSpacePerThread(); 415 return storage + ArchiveSpacePerThread();
416 } 416 }
417 417
418 int Debug::ArchiveSpacePerThread() { return 0; } 418 int Debug::ArchiveSpacePerThread() { return 0; }
419 419
420 void Debug::Iterate(ObjectVisitor* v) { 420 void Debug::Iterate(RootVisitor* v) {
421 v->VisitPointer(&thread_local_.return_value_); 421 v->VisitRootPointer(Root::kDebug, &thread_local_.return_value_);
422 v->VisitPointer(&thread_local_.suspended_generator_); 422 v->VisitRootPointer(Root::kDebug, &thread_local_.suspended_generator_);
423 v->VisitPointer(&thread_local_.ignore_step_into_function_); 423 v->VisitRootPointer(Root::kDebug, &thread_local_.ignore_step_into_function_);
424 } 424 }
425 425
426 DebugInfoListNode::DebugInfoListNode(DebugInfo* debug_info): next_(NULL) { 426 DebugInfoListNode::DebugInfoListNode(DebugInfo* debug_info): next_(NULL) {
427 // Globalize the request debug info object and make it weak. 427 // Globalize the request debug info object and make it weak.
428 GlobalHandles* global_handles = debug_info->GetIsolate()->global_handles(); 428 GlobalHandles* global_handles = debug_info->GetIsolate()->global_handles();
429 debug_info_ = global_handles->Create(debug_info).location(); 429 debug_info_ = global_handles->Create(debug_info).location();
430 } 430 }
431 431
432 432
433 DebugInfoListNode::~DebugInfoListNode() { 433 DebugInfoListNode::~DebugInfoListNode() {
(...skipping 2019 matching lines...) Expand 10 before | Expand all | Expand 10 after
2453 isolate_->Throw(*isolate_->factory()->NewEvalError( 2453 isolate_->Throw(*isolate_->factory()->NewEvalError(
2454 MessageTemplate::kNoSideEffectDebugEvaluate)); 2454 MessageTemplate::kNoSideEffectDebugEvaluate));
2455 } 2455 }
2456 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_); 2456 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_);
2457 isolate_->debug()->UpdateHookOnFunctionCall(); 2457 isolate_->debug()->UpdateHookOnFunctionCall();
2458 isolate_->debug()->side_effect_check_failed_ = false; 2458 isolate_->debug()->side_effect_check_failed_ = false;
2459 } 2459 }
2460 2460
2461 } // namespace internal 2461 } // namespace internal
2462 } // namespace v8 2462 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.h ('k') | src/frames.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698