Issue 2801043003: Revert "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2801043003: Revert "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes." (Closed)

Created:
3 years, 8 months ago by sra1

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes." Need to fix a warning. TBR=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/810f0b5538221673b1ee8014b04cb95a14c40ce7

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -164 lines)			Patch
M	pkg/compiler/lib/src/ssa/nodes.dart	View	3 chunks	+52 lines, -130 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/optimize.dart	View	4 chunks	+10 lines, -31 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/types_propagation.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

sra1

3 years, 8 months ago (2017-04-06 19:07:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
810f0b5538221673b1ee8014b04cb95a14c40ce7 (presubmit successful).