Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: test/inspector/inspector-impl.cc

Issue 2801023003: Revert of [inspector] move console to builtins (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/v8.gyp ('k') | test/inspector/runtime/console-spec.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "test/inspector/inspector-impl.h" 5 #include "test/inspector/inspector-impl.h"
6 6
7 #include "include/v8.h" 7 #include "include/v8.h"
8 8
9 #include "src/vector.h" 9 #include "src/vector.h"
10 10
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 v8::base::Semaphore* ready_semaphore) { 200 v8::base::Semaphore* ready_semaphore) {
201 task_runner_->Append(new DisconnectTask(this)); 201 task_runner_->Append(new DisconnectTask(this));
202 task_runner_->Append(new ConnectTask(this, ready_semaphore)); 202 task_runner_->Append(new ConnectTask(this, ready_semaphore));
203 } 203 }
204 204
205 void InspectorClientImpl::disconnect() { 205 void InspectorClientImpl::disconnect() {
206 for (const auto& it : sessions_) { 206 for (const auto& it : sessions_) {
207 states_[it.first] = it.second->stateJSON(); 207 states_[it.first] = it.second->stateJSON();
208 } 208 }
209 sessions_.clear(); 209 sessions_.clear();
210 inspector_.reset();
211 } 210 }
212 211
213 void InspectorClientImpl::scheduleCreateContextGroup( 212 void InspectorClientImpl::scheduleCreateContextGroup(
214 v8::ExtensionConfiguration* extensions, 213 v8::ExtensionConfiguration* extensions,
215 v8::base::Semaphore* ready_semaphore, int* context_group_id) { 214 v8::base::Semaphore* ready_semaphore, int* context_group_id) {
216 task_runner_->Append(new CreateContextGroupTask( 215 task_runner_->Append(new CreateContextGroupTask(
217 this, extensions, ready_semaphore, context_group_id)); 216 this, extensions, ready_semaphore, context_group_id));
218 } 217 }
219 218
220 int InspectorClientImpl::createContextGroup( 219 int InspectorClientImpl::createContextGroup(
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 } 341 }
343 342
344 void SendMessageToBackendExtension::SendMessageToBackend( 343 void SendMessageToBackendExtension::SendMessageToBackend(
345 const v8::FunctionCallbackInfo<v8::Value>& args) { 344 const v8::FunctionCallbackInfo<v8::Value>& args) {
346 CHECK(backend_task_runner_); 345 CHECK(backend_task_runner_);
347 CHECK(args.Length() == 2 && args[0]->IsString() && args[1]->IsInt32()); 346 CHECK(args.Length() == 2 && args[0]->IsString() && args[1]->IsInt32());
348 v8::Local<v8::String> message = args[0].As<v8::String>(); 347 v8::Local<v8::String> message = args[0].As<v8::String>();
349 backend_task_runner_->Append(new SendMessageToBackendTask( 348 backend_task_runner_->Append(new SendMessageToBackendTask(
350 ToVector(message), args[1].As<v8::Int32>()->Value())); 349 ToVector(message), args[1].As<v8::Int32>()->Value()));
351 } 350 }
OLDNEW
« no previous file with comments | « src/v8.gyp ('k') | test/inspector/runtime/console-spec.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698