Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/cert/internal/path_builder_unittest.cc

Issue 2800993002: Add a key purpose parameter to Certificate PathBuilder. (Closed)
Patch Set: More cast comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/cast_certificate/cast_cert_validator.cc ('K') | « net/cert/internal/path_builder_pkits_unittest.cc ('k') | net/cert/internal/path_builder_verify_certificate_chain_unittest.cc » ('j') | net/cert/internal/verify_certificate_chain.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/path_builder_unittest.cc
diff --git a/net/cert/internal/path_builder_unittest.cc b/net/cert/internal/path_builder_unittest.cc
index 90ee9c71b6d6ea2abde436241cec06dd32a5e836..ffe28ba85588baf3586fe1f8863fff42ca173181 100644
--- a/net/cert/internal/path_builder_unittest.cc
+++ b/net/cert/internal/path_builder_unittest.cc
@@ -160,7 +160,7 @@ TEST_F(PathBuilderMultiRootTest, TargetHasNameAndSpkiOfTrustAnchor) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -180,7 +180,7 @@ TEST_F(PathBuilderMultiRootTest, TargetWithSameNameAsTrustAnchorFails) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -210,7 +210,8 @@ TEST_F(PathBuilderMultiRootTest, SelfSignedTrustAnchorSupplementalCert) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(b_by_c_, &trust_store, &signature_policy_,
- expired_time, &result);
+ expired_time, KeyPurpose::KEY_PURPOSE_ANY,
+ &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -243,7 +244,7 @@ TEST_F(PathBuilderMultiRootTest, TargetIsSelfSignedTrustAnchor) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(e_by_e_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -262,7 +263,7 @@ TEST_F(PathBuilderMultiRootTest, TargetDirectlySignedByTrustAnchor) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -289,7 +290,7 @@ TEST_F(PathBuilderMultiRootTest, TriesSyncFirst) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&async_certs);
path_builder.AddCertIssuerSource(&sync_certs);
@@ -317,7 +318,7 @@ TEST_F(PathBuilderMultiRootTest, TestAsyncSimultaneous) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&async_certs1);
path_builder.AddCertIssuerSource(&async_certs2);
path_builder.AddCertIssuerSource(&sync_certs);
@@ -344,7 +345,7 @@ TEST_F(PathBuilderMultiRootTest, TestLongChain) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -377,7 +378,7 @@ TEST_F(PathBuilderMultiRootTest, TestBacktracking) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.AddCertIssuerSource(&async_certs);
@@ -416,7 +417,7 @@ TEST_F(PathBuilderMultiRootTest, TestCertIssuerOrdering) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(a_by_b_, &trust_store, &signature_policy_,
- time_, &result);
+ time_, KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -507,7 +508,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestRolloverOnlyOldRootTrusted) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -555,7 +556,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestRolloverBothRootsTrusted) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -591,7 +592,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestAnchorsNoMatchAndNoIssuerSources) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -623,7 +624,8 @@ TEST_F(PathBuilderKeyRolloverTest, TestMultipleRootMatchesOnlyOneWorks) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store_collection,
- &signature_policy_, time_, &result);
+ &signature_policy_, time_,
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -673,7 +675,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestRolloverLongChain) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.AddCertIssuerSource(&async_certs);
@@ -730,7 +732,8 @@ TEST_F(PathBuilderKeyRolloverTest, TestEndEntityIsTrustRoot) {
CertPathBuilder::Result result;
// Newintermediate is also the target cert.
CertPathBuilder path_builder(newintermediate_, &trust_store,
- &signature_policy_, time_, &result);
+ &signature_policy_, time_,
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -754,7 +757,7 @@ TEST_F(PathBuilderKeyRolloverTest,
CertPathBuilder::Result result;
// Newroot is the target cert.
CertPathBuilder path_builder(newroot_, &trust_store, &signature_policy_,
- time_, &result);
+ time_, KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -775,7 +778,7 @@ TEST_F(PathBuilderKeyRolloverTest,
CertPathBuilder::Result result;
// Newroot is the target cert.
CertPathBuilder path_builder(newroot_, &trust_store, &signature_policy_,
- time_, &result);
+ time_, KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.Run();
@@ -823,7 +826,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestDuplicateIntermediates) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs1);
path_builder.AddCertIssuerSource(&sync_certs2);
path_builder.AddCertIssuerSource(&async_certs);
@@ -877,7 +880,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestDuplicateIntermediateAndRoot) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&sync_certs);
path_builder.Run();
@@ -952,7 +955,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestMultipleAsyncIssuersFromSingleSource) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&cert_issuer_source);
// Create the mock CertIssuerSource::Request...
@@ -1031,7 +1034,7 @@ TEST_F(PathBuilderKeyRolloverTest, TestDuplicateAsyncIntermediates) {
CertPathBuilder::Result result;
CertPathBuilder path_builder(target_, &trust_store, &signature_policy_, time_,
- &result);
+ KeyPurpose::KEY_PURPOSE_ANY, &result);
path_builder.AddCertIssuerSource(&cert_issuer_source);
// Create the mock CertIssuerSource::Request...
« components/cast_certificate/cast_cert_validator.cc ('K') | « net/cert/internal/path_builder_pkits_unittest.cc ('k') | net/cert/internal/path_builder_verify_certificate_chain_unittest.cc » ('j') | net/cert/internal/verify_certificate_chain.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698