Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2800953002: [MD settings] support RTL in paper-slider (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] support RTL in paper-slider This CL change the third_party/polymer code to support rtl in paper-slider by mirroring the control and input in rtl locales. BUG=696437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js View 4 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dschuyler
There is a PR for this at https://github.com/PolymerElements/paper-slider/pull/181
3 years, 8 months ago (2017-04-05 22:53:36 UTC) #5
tommycli
On 2017/04/05 22:53:36, dschuyler wrote: > There is a PR for this at > https://github.com/PolymerElements/paper-slider/pull/181 ...
3 years, 8 months ago (2017-04-05 23:09:16 UTC) #6
dschuyler
On 2017/04/05 23:09:16, tommycli wrote: > On 2017/04/05 22:53:36, dschuyler wrote: > > There is ...
3 years, 8 months ago (2017-04-05 23:21:00 UTC) #7
dschuyler
On 2017/04/05 23:21:00, dschuyler wrote: > On 2017/04/05 23:09:16, tommycli wrote: > > On 2017/04/05 ...
3 years, 8 months ago (2017-04-05 23:33:28 UTC) #8
dschuyler
3 years, 8 months ago (2017-04-07 19:10:39 UTC) #11
On 2017/04/05 23:33:28, dschuyler wrote:
> On 2017/04/05 23:21:00, dschuyler wrote:
> > On 2017/04/05 23:09:16, tommycli wrote:
> > > On 2017/04/05 22:53:36, dschuyler wrote:
> > > > There is a PR for this at
> > > > https://github.com/PolymerElements/paper-slider/pull/181
> > > 
> > > I thought our standard procedure was to get the pull request accepted,
then
> do
> > a
> > > polymer roll after they issued a new version?
> > > 
> > > Did we change our standard to make changes locally ahead of pull request
> > > acceptance?
> > 
> > Yes, that was a topic from a team stand-up some time ago (unless it changed
> back
> > again).
> 
> If Polymer responds to the PR relatively soon then we can go with the PR. I'll
> check on that (give me a day or so).

The Polymer PR went through (https://codereview.chromium.org/2801193002/).
I'll close this one.

Powered by Google App Engine
This is Rietveld 408576698