Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2800923002: Assume Resource is always non-null in external classic script (Closed)
Patch Set: Assume Resource is always non-null in external classic script Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index 27bba37015b40bd5592ecea7b13b70afe2f3a9fc..bf589315c35aac506df393c99fd852b9994c0ea3 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -735,7 +735,8 @@ bool ScriptLoader::doExecuteScript(const ScriptSourceCode& sourceCode) {
AccessControlStatus accessControlStatus = NotSharableCrossOrigin;
if (!m_isExternalScript) {
accessControlStatus = SharableCrossOrigin;
- } else if (sourceCode.resource()) {
+ } else {
+ CHECK(sourceCode.resource());
accessControlStatus = sourceCode.resource()->calculateAccessControlStatus(
m_element->document().getSecurityOrigin());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698