Issue 2800883002: Conservatively disable use of integer division on Android ARM64 devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2800883002: Conservatively disable use of integer division on Android ARM64 devices. (Closed)

Created:
3 years, 8 months ago by rmacnak

Modified:
3 years, 8 months ago

Reviewers:
zra, jsimmons1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Conservatively disable use of integer division on Android ARM64 devices. R=jsimmons@google.com Committed: https://github.com/dart-lang/sdk/commit/683077944b67ccd21dd656cf8fb573a45eaeb340

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	runtime/vm/cpu_arm.cc	View	1	1 chunk	+14 lines, -4 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #2 (id:20001) manually as 683077944b67ccd21dd656cf8fb573a45eaeb340 (presubmit successful).

3 years, 8 months ago (2017-04-05 19:45:09 UTC) #5

zra

3 years, 8 months ago (2017-04-05 20:29:10 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/2800883002/diff/20001/runtime/vm/cpu_arm.cc
File runtime/vm/cpu_arm.cc (right):

https://codereview.chromium.org/2800883002/diff/20001/runtime/vm/cpu_arm.cc#n...
runtime/vm/cpu_arm.cc:216: bool is_android = false;
I'd prefer using OS::Name() over HOST_OS_ANDROID. And shouldn't it be
TARGET_OS_ANDROID, anyway?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages