Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 2800853004: UKM that threads together multiple form interaction events. (Closed)
Patch Set: Uses size_t for local and server record type count. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 90e7ecd5f7852e2b95e173505cbf1ef5b167de4b..9cac362edffbfccc97d764752a1a12a9a0928548 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -43,8 +43,6 @@
#define ENABLE_FORM_DEBUG_DUMP
#endif
-class GURL;
-
namespace gfx {
class RectF;
}
@@ -270,6 +268,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,
return &form_structures_;
}
+ AutofillMetrics::FormInteractionsUkmLogger* form_interactions_ukm_logger() {
+ return form_interactions_ukm_logger_.get();
+ }
+
// Exposed for testing.
AutofillExternalDelegate* external_delegate() {
return external_delegate_;
@@ -510,6 +512,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,
// Handles single-field autocomplete form data.
std::unique_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
+ // Utility for logging URL keyed metrics.
+ std::unique_ptr<AutofillMetrics::FormInteractionsUkmLogger>
+ form_interactions_ukm_logger_;
+
// Utilities for logging form events.
std::unique_ptr<AutofillMetrics::FormEventLogger> address_form_event_logger_;
std::unique_ptr<AutofillMetrics::FormEventLogger>
@@ -595,6 +601,7 @@ class AutofillManager : public AutofillDownloadManager::Observer,
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AddressSubmittedFormEvents);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AddressWillSubmitFormEvents);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AddressSuggestionsCount);
+ FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AutofillFormSubmittedState);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AutofillIsEnabledAtPageLoad);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, CreditCardSelectedFormEvents);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, CreditCardFilledFormEvents);
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698