UKM that threads together multiple form interaction events.

components/autofill/core/browser/form_structure.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_structure.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 662 matching lines @@
   UpdateAutofillCount();
 
   // The form signature should match between query and upload requests to the
   // server. On many websites, form elements are dynamically added, removed, or
   // rearranged via JavaScript between page load and form submission, so we
   // copy over the |form_signature_field_names_| corresponding to the query
   // request.
   form_signature_ = cached_form.form_signature_;
 }
 
-void FormStructure::LogQualityMetrics(const base::TimeTicks& load_time,
-                                      const base::TimeTicks& interaction_time,
-                                      const base::TimeTicks& submission_time,
-                                      rappor::RapporServiceImpl* rappor_service,
-                                      bool did_show_suggestions,
-                                      bool observed_submission) const {
+AutofillMetrics::AutofillFormSubmittedState FormStructure::LogQualityMetrics(
+    const base::TimeTicks& load_time,
+    const base::TimeTicks& interaction_time,
+    const base::TimeTicks& submission_time,
+    rappor::RapporServiceImpl* rappor_service,
+    bool did_show_suggestions,
+    bool observed_submission) const {
   size_t num_detected_field_types = 0;
   size_t num_server_mismatches = 0;
   size_t num_heuristic_mismatches = 0;
   size_t num_edited_autofilled_fields = 0;
   bool did_autofill_all_possible_fields = true;
   bool did_autofill_some_possible_fields = false;
   for (size_t i = 0; i < field_count(); ++i) {
     auto* const field = this->field(i);
 
     // No further logging for password fields.  Those are primarily related to a
@@ skipping 84 matching lines @@
       AutofillMetrics::LogOverallTypePrediction(AutofillMetrics::TYPE_MISMATCH,
                                                 field_type, metric_type);
     }
   }
 
   AutofillMetrics::LogNumberOfEditedAutofilledFields(
       num_edited_autofilled_fields, observed_submission);
 
   // We log "submission" and duration metrics if we are here after observing a
   // submission event.
+  AutofillMetrics::AutofillFormSubmittedState state =

[sebsg, 2017/04/10 19:20:19]

I find it weird to return this value, but the function is very very messy, so I
understand why you did it. Could you open a but and add a TODO comment here to
clean this? leave it available for the autofill team. 

Thanks!

[csashi, 2017/04/10 20:15:58]

I noticed that LogQualityMetrics was already taking in a Rappor (another kind of
logger), so I added the new logger as an additional parameter.

I did not create a bug but I created a TODO to perhaps modify the function name
or split it up. 

+      AutofillMetrics::AUTOFILL_FORM_SUBMITTED_STATE_ENUM_SIZE;
   if (observed_submission) {
     if (num_detected_field_types < kRequiredFieldsForPredictionRoutines) {
-      AutofillMetrics::LogAutofillFormSubmittedState(
-          AutofillMetrics::NON_FILLABLE_FORM_OR_NEW_DATA);
+      state = AutofillMetrics::NON_FILLABLE_FORM_OR_NEW_DATA;
     } else {
       if (did_autofill_all_possible_fields) {
-        AutofillMetrics::LogAutofillFormSubmittedState(
-            AutofillMetrics::FILLABLE_FORM_AUTOFILLED_ALL);
+        state = AutofillMetrics::FILLABLE_FORM_AUTOFILLED_ALL;
       } else if (did_autofill_some_possible_fields) {
-        AutofillMetrics::LogAutofillFormSubmittedState(
-            AutofillMetrics::FILLABLE_FORM_AUTOFILLED_SOME);
+        state = AutofillMetrics::FILLABLE_FORM_AUTOFILLED_SOME;
       } else if (!did_show_suggestions) {
-        AutofillMetrics::LogAutofillFormSubmittedState(
-            AutofillMetrics::
-                FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS);
+        state = AutofillMetrics::
+            FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS;
       } else {
-        AutofillMetrics::LogAutofillFormSubmittedState(
-            AutofillMetrics::
-                FILLABLE_FORM_AUTOFILLED_NONE_DID_SHOW_SUGGESTIONS);
+        state =
+            AutofillMetrics::FILLABLE_FORM_AUTOFILLED_NONE_DID_SHOW_SUGGESTIONS;
       }
 
       // Log some RAPPOR metrics for problematic cases.
       if (num_server_mismatches >= kNumberOfMismatchesThreshold) {
         rappor::SampleDomainAndRegistryFromGURL(
             rappor_service, "Autofill.HighNumberOfServerMismatches",
             source_url_);
       }
       if (num_heuristic_mismatches >= kNumberOfMismatchesThreshold) {
         rappor::SampleDomainAndRegistryFromGURL(
@@ skipping 27 matching lines @@
         if (did_autofill_some_possible_fields) {
           AutofillMetrics::LogFormFillDurationFromInteractionWithAutofill(
               elapsed);
         } else {
           AutofillMetrics::LogFormFillDurationFromInteractionWithoutAutofill(
               elapsed);
         }
       }
     }
   }
+  return state;
 }
 
 void FormStructure::LogQualityMetricsBasedOnAutocomplete() const {
   for (const auto& field : fields_) {
     if (field->html_type() != HTML_TYPE_UNSPECIFIED &&
         field->html_type() != HTML_TYPE_UNRECOGNIZED) {
       // The type inferred by the autocomplete attribute.
       AutofillType type(field->html_type(), field->html_mode());
       ServerFieldType actual_field_type = type.GetStorableType();
 
@@ skipping 469 matching lines @@
               filtered_strings[0].at(prefix_len)) {
         // Mismatch found.
         return filtered_strings[i].substr(0, prefix_len);
       }
     }
   }
   return filtered_strings[0];
 }
 
 }  // namespace autofill