UKM that threads together multiple form interaction events.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
+#include <utility>
+#include <vector>
 
 #include "base/macros.h"
 #include "components/autofill/core/browser/autofill_client.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/common/form_field_data.h"
 
 namespace base {
 class TimeDelta;
 }  // namespace base
 
 namespace ukm {
 class UkmService;
 }  // namespace ukm
 
 namespace internal {
 // Name constants are exposed here so they can be referenced from tests.
 extern const char kUKMCardUploadDecisionEntryName[];
 extern const char kUKMCardUploadDecisionMetricName[];
 extern const char kUKMDeveloperEngagementEntryName[];
 extern const char kUKMDeveloperEngagementMetricName[];
+extern const char kUKMFormInteractionsEntryName[];
+extern const char kUKMFormInteractionsAutofillFormSubmittedStateMetricName[];
+extern const char kUKMFormInteractionsUserHappinessMetricMetricName[];
+extern const char kUKMFormInteractionsAddressFormEventMetricName[];
+extern const char kUKMFormInteractionsCreditCardFormEventMetricName[];
+extern const char kUKMFormInteractionsUnmaskPromptEventMetricName[];
 }  // namespace internal
 
 namespace autofill {
 
 class AutofillMetrics {
  public:
   enum AutofillProfileAction {
     EXISTING_PROFILE_USED,
     EXISTING_PROFILE_UPDATED,
     NEW_PROFILE_CREATED,
@@ skipping 494 matching lines @@
 
   // For mesuring how wallet addresses are converted to local profiles.
   enum WalletAddressConversionType : int {
     // The converted wallet address was merged into an existing local profile.
     CONVERTED_ADDRESS_MERGED,
     // The converted wallet address was added as a new local profile.
     CONVERTED_ADDRESS_ADDED,
     NUM_CONVERTED_ADDRESS_CONVERSION_TYPES
   };
 
+  // Utility to log URL keyed |AutofillFormSubmittedState|,
+  // |UserHappinessMetric|, |FormEvent| and |UnmaskPromptEvent|.
+  class UkmLogger {

[sebsg, 2017/04/10 19:20:19]

Do you think we could rename to something like FormInteractionsUkmLogger? This
one feels very broad :)

[csashi, 2017/04/10 20:15:58]

Done.

+   public:
+    explicit UkmLogger(ukm::UkmService* ukm_service);
+    ~UkmLogger();
+
+    const GURL& url() const { return url_; }
+    void set_url(const GURL& url) { url_ = url; }
+
+    void LogAutofillFormSubmittedState(AutofillFormSubmittedState state);
+    void LogUserHappinessMetric(UserHappinessMetric metric);
+    void LogAddressFormEvent(FormEvent event);
+    void LogCreditCardFormEvent(FormEvent event);
+    void LogUnmaskPromptEvent(UnmaskPromptEvent event);
+    void LogUkm();
+
+   private:
+    enum MetricType {
+      AUTOFILL_FORM_SUBMITTED_STATE,  // |AutofillFormSubmittedState|
+      USER_HAPPINESS_METRIC,          // |UserHappinessMetric|
+      ADDRESS_FORM_EVENT,             // |FormEvent| for address
+      CREDIT_CARD_FORM_EVENT,         // |FormEvent| for credit_card
+      UNMASK_PROMPT_EVENT,            // |UnmaskPromptEvent|
+
+      NUM_METRIC_TYPES,
+    };
+    ukm::UkmService* ukm_service_;  // Weak reference.
+    GURL url_;
+    std::vector<std::pair<MetricType, int>> metrics_;
+  };
+
   static void LogCardUploadDecisionMetric(CardUploadDecisionMetric metric);
   static void LogCreditCardInfoBarMetric(InfoBarMetric metric,
                                          bool is_uploading);
   static void LogCreditCardFillingInfoBarMetric(InfoBarMetric metric);
   static void LogSaveCardPromptMetric(SaveCardPromptMetric metric,
                                       bool is_uploading,
                                       bool is_reshow);
   static void LogScanCreditCardPromptMetric(ScanCreditCardPromptMetric metric);
 
   // Should be called when credit card scan is finished. |duration| should be
@@ skipping 106 matching lines @@
 
   // This should be called each time a server response is parsed for a form.
   static void LogServerResponseHasDataForForm(bool has_data);
 
   // This should be called at each form submission to indicate what profile
   // action happened.
   static void LogProfileActionOnFormSubmitted(AutofillProfileAction action);
 
   // This should be called at each form submission to indicate the autofilled
   // state of the form.
-  static void LogAutofillFormSubmittedState(AutofillFormSubmittedState state);
+  static void LogAutofillFormSubmittedState(AutofillFormSubmittedState state,
+                                            UkmLogger* ukm_logger);
 
   // This should be called when determining the heuristic types for a form's
   // fields.
   static void LogDetermineHeuristicTypesTiming(const base::TimeDelta& duration);
 
   // This should be called when parsing each form.
   static void LogParseFormTiming(const base::TimeDelta& duration);
 
   // Log how many profiles were considered for the deduplication process.
   static void LogNumberOfProfilesConsideredForDedupe(size_t num_considered);
@@ skipping 25 matching lines @@
   static void LogDeveloperEngagementUkm(
       ukm::UkmService* ukm_service,
       const GURL& url,
       AutofillMetrics::DeveloperEngagementMetric metric);
 
   // Logs the the |ukm_entry_name| with the specified |url| and the specified
   // |metrics|. Returns whether the ukm was sucessfully logged.
   static bool LogUkm(ukm::UkmService* ukm_service,
                      const GURL& url,
                      const std::string& ukm_entry_name,
-                     const std::map<std::string, int>& metrics);
+                     const std::vector<std::pair<const char*, int>>& metrics);
 
-  // Utility to autofill form events in the relevant histograms depending on
+  // Utility to log autofill form events in the relevant histograms depending on
   // the presence of server and/or local data.
   class FormEventLogger {
    public:
-    FormEventLogger(bool is_for_credit_card);
+    FormEventLogger(bool is_for_credit_card, UkmLogger* ukm_logger);
 
     inline void set_is_server_data_available(bool is_server_data_available) {
       is_server_data_available_ = is_server_data_available;
     }
 
     inline void set_is_local_data_available(bool is_local_data_available) {
       is_local_data_available_ = is_local_data_available;
     }
 
     inline void set_is_context_secure(bool is_context_secure) {
@@ skipping 12 matching lines @@
     // the card is upgraded to a full card.
     void OnDidFillSuggestion(const CreditCard& credit_card);
 
     void OnDidFillSuggestion(const AutofillProfile& profile);
 
     void OnWillSubmitForm();
 
     void OnFormSubmitted();
 
    private:
-    void Log(FormEvent event) const;
+    void Log(FormEvent event, bool log_ukm) const;
 
     bool is_for_credit_card_;
     bool is_server_data_available_;
     bool is_local_data_available_;
     bool is_context_secure_;
     bool has_logged_interacted_;
     bool has_logged_suggestions_shown_;
     bool has_logged_masked_server_card_suggestion_selected_;
     bool has_logged_suggestion_filled_;
     bool has_logged_will_submit_;
     bool has_logged_submitted_;
     bool logged_suggestion_filled_was_server_data_;
     bool logged_suggestion_filled_was_masked_server_card_;
 
     // The last field that was polled for suggestions.
     FormFieldData last_polled_field_;
+
+    UkmLogger* ukm_logger_;  // Weak reference.
   };
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_