tools/metrics/ukm/ukm.xml - Issue 2800853004: UKM that threads together multiple form interaction events.

Side by Side Diff: tools/metrics/ukm/ukm.xml

Issue 2800853004: UKM that threads together multiple form interaction events. (Closed)

Patch Set: Logs each form interaction event in a separate UkmEntry, includes time_delta as a metric. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!--	1 <!--

2 Copyright 2017 The Chromium Authors. All rights reserved.	2 Copyright 2017 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <!--	7 <!--

8 This file is used to generate a comprehensive list of Chrome UKM metrics	8 This file is used to generate a comprehensive list of Chrome UKM metrics

9 along with a detailed description for each metric.	9 along with a detailed description for each metric.

10 -->	10 -->

(...skipping 20 matching lines...) Expand all Loading...
31 <metric name="PaintTiming.NavigationToFirstContentfulPaint"/>	31 <metric name="PaintTiming.NavigationToFirstContentfulPaint"/>

32 <metric name="ParseTiming.NavigationToParseStart">	32 <metric name="ParseTiming.NavigationToParseStart">

33 <summary>	33 <summary>

34 Time from navigation to parse start in ms.	34 Time from navigation to parse start in ms.

35 </summary>	35 </summary>

36 </metric>	36 </metric>

37 </event>	37 </event>

38	38

39 <event name="Autofill.CardUploadDecision">	39 <event name="Autofill.CardUploadDecision">

40 <owner>sebsg@chromium.org</owner>	40 <owner>sebsg@chromium.org</owner>

	41 <summary>

	42 Recorded when we decide whether to offer Card Upload to Payments.

	43 </summary>

41 <metric name="UploadDecision"/>	44 <metric name="UploadDecision"/>

42 </event>	45 </event>

43	46

	47 <event name="Autofill.DeveloperEngagement">

	48 <owner>csashi@google.com</owner>

	49 <summary>

	50 Recorded when we parse a form.

	51 </summary>

	52 <metric name="DeveloperEngagement"/>

	53 </event>

	54

	55 <event name="AutofillFormSubmittedState">

	56 <owner>csashi@google.com</owner>

	57 <metric name="AutofillFormSubmittedState"/>

	58 <metric name="MillisecondsSinceFormLoaded"/>

	59 </event>

	60

	61 <event name="FormEvent.Address">

	62 <owner>csashi@google.com</owner>

	63 <summary>

	64 FormEvent for address/profile forms.

	65 </summary>

	66 <metric name="FormEvent.Address"/>

	67 <metric name="MillisecondsSinceFormLoaded"/>

	68 </event>

	69

	70 <event name="FormEvent.CreditCard">

	71 <owner>csashi@google.com</owner>

	72 <summary>

	73 FormEvent for credit card forms.

	74 </summary>

	75 <metric name="FormEvent.CreditCard"/>

	76 <metric name="MillisecondsSinceFormLoaded"/>

	77 </event>

	78

	79 <event name="UnmaskPromptEvent">

	80 <owner>csashi@google.com</owner>

	81 <metric name="MillisecondsSinceFormLoaded"/>

	82 <metric name="UnmaskPromptEvent"/>
	Steven Holte 2017/04/12 02:26:31 It seems like this is always AutoFill::UNMASK_PROM It seems like this is always AutoFill::UNMASK_PROMPT_SHOWN. Is this needed? csashi 2017/04/12 05:53:58 Acknowledged. I was planning on adding other Unmas Show quoted text On 2017/04/12 02:26:31, Steven Holte wrote: > It seems like this is always AutoFill::UNMASK_PROMPT_SHOWN. Is this needed? Acknowledged. I was planning on adding other UnmaskPromptEvents too but they get logged at different locations. To limit the scope of this change, I just logged UNMASK_PROMPT_SHOWN, but it would be better to add it back when I have all the unmask events.
	83 </event>

	84

	85 <event name="UserHappinessMetric">
	Steven Holte 2017/04/12 02:26:31 A lot of these metric/events names seem pretty amb A lot of these metric/events names seem pretty ambiguous. It would be helpful if you describe these in terms of how they tell you what has happened on the client. csashi 2017/04/12 05:53:59 Acknowledged. I will update up this after you revi Show quoted text On 2017/04/12 02:26:31, Steven Holte wrote: > A lot of these metric/events names seem pretty ambiguous. It would be helpful > if you describe these in terms of how they tell you what has happened on the > client. Acknowledged. I will update up this after you review the changes to the metrics/entries. csashi 2017/04/12 18:54:17 Done. Show quoted text On 2017/04/12 05:53:59, csashi wrote: > On 2017/04/12 02:26:31, Steven Holte wrote: > > A lot of these metric/events names seem pretty ambiguous. It would be helpful > > if you describe these in terms of how they tell you what has happened on the > > client. > > Acknowledged. I will update up this after you review the changes to the > metrics/entries. Done.
	86 <metric name="MillisecondsSinceFormLoaded"/>

	87 <metric name="UserHappinessMetric"/>

	88 </event>

	89

44 </ukm-configuration>	90 </ukm-configuration>

OLD	NEW

« components/autofill/core/browser/autofill_metrics.cc ('K') | « components/ukm/test_ukm_service.cc ('k') | no next file » | no next file with comments »