Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2800843002: PlzNavigate: fix nullptr bug in NavigationResourceHandler (Closed)

Created:
3 years, 8 months ago by clamy
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix nullptr bug in NavigationResourceHandler The refactoring of the ResourceHandlers may have introduced a potential nullptr dereference in NavigationResourceHandler::OnRequestRedirected and NavigationResourceHandler::OnResponseStarted. This CL makes sure we cancel the load and return early if the NavigationURLLoaderImplCore has been reset. BUG=705217 Review-Url: https://codereview.chromium.org/2800843002 Cr-Commit-Position: refs/heads/master@{#462174} Committed: https://chromium.googlesource.com/chromium/src/+/7a3b81227dcba0c840b6c5bf1c92b252c2503e90

Patch Set 1 #

Patch Set 2 : Removed obsolete TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/loader/navigation_resource_handler.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
clamy
@nasko: PTAL
3 years, 8 months ago (2017-04-05 18:03:39 UTC) #3
nasko
LGTM
3 years, 8 months ago (2017-04-05 18:15:14 UTC) #4
clamy
Thanks!
3 years, 8 months ago (2017-04-05 18:17:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800843002/20001
3 years, 8 months ago (2017-04-05 18:18:44 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 19:24:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a3b81227dcba0c840b6c5bf1c92...

Powered by Google App Engine
This is Rietveld 408576698