content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc - Issue 2800833005: Remove SurfaceFactory Occurrences Outside Of cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2800833005: Remove SurfaceFactory Occurrences Outside Of cc (Closed)

Patch Set: Make SurfaceFactoryClient Implementation In CompositorFrameSinkSupport Public Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

index 2a10a40c78cb89e8ae20757ec82d7604c9856912..86493be1cd720b372da46341b56a1885c189f6b6 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

@@ -17,7 +17,6 @@

#include "build/build_config.h"

#include "cc/surfaces/compositor_frame_sink_support.h"

#include "cc/surfaces/surface.h"

-#include "cc/surfaces/surface_factory.h"

#include "cc/surfaces/surface_manager.h"

#include "cc/surfaces/surface_sequence.h"

#include "cc/test/begin_frame_args_test.h"

@@ -243,8 +242,7 @@ TEST_F(RenderWidgetHostViewChildFrameTest, ForwardsBeginFrameAcks) {

// Replace BeginFrameSource so that we can observe acknowledgments.

cc::FakeExternalBeginFrameSource source(0.f, false);

uint32_t source_id = source.source_id();

- static_cast<cc::SurfaceFactoryClient*>(view_->support_.get())

- ->SetBeginFrameSource(&source);

+ view_->support_->SetBeginFrameSource(&source);

view_->SetNeedsBeginFrames(true);

{