Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc

Issue 2800833002: Add a TODO for crbug/703565 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/web_view/internal/translate/web_view_translate_ranker_factory.h" 5 #include "ios/web_view/internal/translate/web_view_translate_ranker_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
(...skipping 29 matching lines...) Expand all
40 web::BrowserState* context) const { 40 web::BrowserState* context) const {
41 WebViewBrowserState* web_view_browser_state = 41 WebViewBrowserState* web_view_browser_state =
42 WebViewBrowserState::FromBrowserState(context); 42 WebViewBrowserState::FromBrowserState(context);
43 std::unique_ptr<translate::TranslateRankerImpl> ranker = 43 std::unique_ptr<translate::TranslateRankerImpl> ranker =
44 base::MakeUnique<translate::TranslateRankerImpl>( 44 base::MakeUnique<translate::TranslateRankerImpl>(
45 translate::TranslateRankerImpl::GetModelPath( 45 translate::TranslateRankerImpl::GetModelPath(
46 web_view_browser_state->GetStatePath()), 46 web_view_browser_state->GetStatePath()),
47 translate::TranslateRankerImpl::GetModelURL()); 47 translate::TranslateRankerImpl::GetModelURL());
48 // WebView has no consumer of translate ranker events, so don't generate them. 48 // WebView has no consumer of translate ranker events, so don't generate them.
49 ranker->EnableLogging(false); 49 ranker->EnableLogging(false);
50 return std::move(ranker); // Fails xcode-clang compile without the move. 50
51 // TODO(crbug.com/703565): remove std::move() once Xcode 9.0+ is required.
52 return std::move(ranker);
51 } 53 }
52 54
53 } // namespace ios_web_view 55 } // namespace ios_web_view
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698