Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.h

Issue 2800813006: Move layouet/LayoutView::setSelection() to editing/LayoutSelection (Closed)
Patch Set: nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutView.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutView.h b/third_party/WebKit/Source/core/layout/LayoutView.h
index 78ca1da119ca0823612fed695a16799d4f264a68..ed3ca8df3b96eaca4970fc2d055dc969dd207809 100644
--- a/third_party/WebKit/Source/core/layout/LayoutView.h
+++ b/third_party/WebKit/Source/core/layout/LayoutView.h
@@ -148,22 +148,10 @@ class CORE_EXPORT LayoutView final : public LayoutBlockFlow {
void PaintBoxDecorationBackground(const PaintInfo&,
const LayoutPoint&) const override;
- enum SelectionPaintInvalidationMode {
- kPaintInvalidationNewXOROld,
- kPaintInvalidationNewMinusOld
- };
- void SetSelection(
- LayoutObject* start,
- int start_pos,
- LayoutObject*,
- int end_pos,
- SelectionPaintInvalidationMode = kPaintInvalidationNewXOROld);
void ClearSelection();
bool HasPendingSelection() const;
void CommitPendingSelection();
- IntRect SelectionBounds();
void SelectionStartEnd(int& start_pos, int& end_pos);
- void InvalidatePaintForSelection();
void AbsoluteRects(Vector<IntRect>&,
const LayoutPoint& accumulated_offset) const override;
@@ -291,25 +279,6 @@ class CORE_EXPORT LayoutView final : public LayoutBlockFlow {
UntracedMember<FrameView> frame_view_;
- // The current selection represented as 2 boundaries.
- // Selection boundaries are represented in LayoutView by a tuple
- // (LayoutObject, DOM node offset).
- // See http://www.w3.org/TR/dom/#range for more information.
- //
- // |m_selectionStartPos| and |m_selectionEndPos| are only valid for
- // |Text| node without 'transform' or 'first-letter'.
- //
- // Those are used for selection painting and paint invalidation upon
- // selection change.
- LayoutObject* selection_start_;
- LayoutObject* selection_end_;
-
- // TODO(yosin): Clarify the meaning of these variables. editing/ passes
- // them as offsets in the DOM tree but layout uses them as offset in the
- // layout tree.
- int selection_start_pos_;
- int selection_end_pos_;
-
// The page logical height.
// This is only used during printing to split the content into pages.
// Outside of printing, this is 0.

Powered by Google App Engine
This is Rietveld 408576698