Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1987)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java

Issue 2800813003: Add new method signature to AppIndexingReporter. (Closed)
Patch Set: add both signatures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java b/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
index 2ebb35badafdd2e2fb5771ff3f5ea86b60772393..4312d822a81d758111147e908363b95afdb16c24 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/historyreport/AppIndexingReporter.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.historyreport;
+import org.chromium.blink.mojom.WebPage;
import org.chromium.chrome.browser.AppHooks;
/** Base class for reporting entities to App Indexing. */
@@ -22,12 +23,23 @@ public class AppIndexingReporter {
* Reports provided entity to on-device index.
* Base class does not implement any reporting, and call is a no-op. Child classes should
* implement this functionality.
+ *
+ * Deprecated, to be removed in follow-up cl, after downstream change.
*/
public void reportEntityJsonLd(String url, String json) {
// Overriden by private class. Base class does nothing.
}
/**
+ * Reports provided entity to on-device index.
+ * Base class does not implement any reporting, and call is a no-op. Child classes should
+ * implement this functionality.
+ */
+ public void reportWebPage(WebPage webpage) {
+ // Overriden by private class. Base class does nothing.
+ }
+
+ /**
* Clears history of reported entities.
* Currently, we do not support clearing only a subset of history. Base class does not implement
* any reporting, and call is a no-op. Child classes should implement this functionality.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698