Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/ppc/macro-assembler-ppc.cc

Issue 2800813002: PPC/S390: Fix to use correct instr to test bitmask (Closed)
Patch Set: cr0 fix for ppc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | src/s390/macro-assembler-s390.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ppc/macro-assembler-ppc.cc
diff --git a/src/ppc/macro-assembler-ppc.cc b/src/ppc/macro-assembler-ppc.cc
index 66fd73bd245082c2f2f07cfd6058f7cbd37709dc..4aa901c1778e12106c3ca22a826aa4e4206f7791 100644
--- a/src/ppc/macro-assembler-ppc.cc
+++ b/src/ppc/macro-assembler-ppc.cc
@@ -2629,7 +2629,7 @@ void MacroAssembler::AssertGeneratorObject(Register object, Register flags) {
// `flags` should be an untagged integer. See `SuspendFlags` in src/globals.h
if (!emit_debug_code()) return;
TestIfSmi(object, r0);
- Check(ne, kOperandIsASmiAndNotAGeneratorObject);
+ Check(ne, kOperandIsASmiAndNotAGeneratorObject, cr0);
// Load map
Register map = object;
@@ -2637,9 +2637,8 @@ void MacroAssembler::AssertGeneratorObject(Register object, Register flags) {
LoadP(map, FieldMemOperand(object, HeapObject::kMapOffset));
Label async, do_check;
- And(ip, flags, Operand(static_cast<int>(SuspendFlags::kGeneratorTypeMask)));
- cmpi(ip, Operand(static_cast<int>(SuspendFlags::kGeneratorTypeMask)));
- bne(&async);
+ TestBitMask(flags, static_cast<int>(SuspendFlags::kGeneratorTypeMask), r0);
+ bne(&async, cr0);
// Check if JSGeneratorObject
CompareInstanceType(map, object, JS_GENERATOR_OBJECT_TYPE);
« no previous file with comments | « src/builtins/s390/builtins-s390.cc ('k') | src/s390/macro-assembler-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698