src/ppc/macro-assembler-ppc.cc - Issue 2800813002: PPC/S390: Fix to use correct instr to test bitmask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/macro-assembler-ppc.cc

Issue 2800813002: PPC/S390: Fix to use correct instr to test bitmask (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ppc/macro-assembler-ppc.cc

diff --git a/src/ppc/macro-assembler-ppc.cc b/src/ppc/macro-assembler-ppc.cc

index 66fd73bd245082c2f2f07cfd6058f7cbd37709dc..8fa26e47c7e3ec4172737176a97fccf1fdfb3f23 100644

--- a/src/ppc/macro-assembler-ppc.cc

+++ b/src/ppc/macro-assembler-ppc.cc

@@ -2637,8 +2637,7 @@ void MacroAssembler::AssertGeneratorObject(Register object, Register flags) {

LoadP(map, FieldMemOperand(object, HeapObject::kMapOffset));

Label async, do_check;

- And(ip, flags, Operand(static_cast<int>(SuspendFlags::kGeneratorTypeMask)));

- cmpi(ip, Operand(static_cast<int>(SuspendFlags::kGeneratorTypeMask)));

+ TestBitMask(flags, static_cast<int>(SuspendFlags::kGeneratorTypeMask), r0);

bne(&async);

// Check if JSGeneratorObject