Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html

Issue 2800723002: Ensure we never remove the style attribute when syncing it from CSSOM. (Closed)
Patch Set: Nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html
diff --git a/third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html b/third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html
index ee68821ba21867b28ce705e1a313f795ad4b9f00..d7e1bb0a0ee90ab826134b4c2d990185a1af4b31 100644
--- a/third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html
+++ b/third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style.html
@@ -1,9 +1,9 @@
<script src="../../resources/dump-as-markup.js"></script>
-<p>This tests removing style attribute after removing CSS property. Undo should bring back the CSS property we removed.</p>
+<p>This tests removing style after removing CSS property. Undo should bring back the CSS property we removed.</p>
<div id="test" contenteditable><span style="font-weight: 900;">test</span></div>
<script>
-Markup.description('This tests removing style attribute after removing CSS property. Undo should bring back the CSS property we removed.');
+Markup.description('This tests removing style after removing CSS property. Undo should bring back the CSS property we removed.');
Markup.dump('test', 'Initially "test" should be bold wrapped with a span');
window.getSelection().selectAllChildren(test);
@@ -11,7 +11,7 @@ document.execCommand('bold', false, null);
Markup.dump('test', 'Unbolding should remove the CSS style and also remove the span');
document.execCommand('undo', false, null);
-Markup.dump('test', 'Undo should bring back both the span and style attribute so that "test" is once again bold');
+Markup.dump('test', 'Undo should bring back both the span and style so that "test" is once again bold');
document.execCommand('redo', false, null);
Markup.dump('test', 'Redo should unbold "test" and there should be no span');
@@ -30,10 +30,10 @@ document.execCommand('bold', false, null);
Markup.dump('test', 'Unbolding should remove the CSS style but shouldn\'t remove the span');
document.execCommand('undo', false, null);
-Markup.dump('test', 'Undo should restore the style attribute and "test" should be bold');
+Markup.dump('test', 'Undo should restore the style and "test" should be bold');
document.execCommand('redo', false, null);
-Markup.dump('test', 'Redo should remove the style attribute again');
+Markup.dump('test', 'Redo should remove the style again');
document.getElementById('test').innerHTML = '<span style="font-weight: 900;">test</span>';
var span = document.getElementById('test').firstChild;
@@ -42,16 +42,16 @@ window.getSelection().selectAllChildren(test);
Markup.dump('test', 'Reset, and added color:blue');
document.execCommand('bold', false, null);
-Markup.dump('test', 'Unbolding should remove the font-weight but shouldn\'t remove the style attribute');
+Markup.dump('test', 'Unbolding should remove the font-weight but shouldn\'t remove the style ');
document.execCommand('undo', false, null);
-Markup.dump('test', 'Undo should reset the style attribute so that "test" is both bold and blue');
+Markup.dump('test', 'Undo should reset the style so that "test" is both bold and blue');
document.execCommand('redo', false, null);
Markup.dump('test', 'Redo should only remove font-weight and leave "test" blue');
document.execCommand('foreColor', false, "#000000");
-Markup.dump('test', 'Setting the forecolor to black should remove both the style attribute and the span');
+Markup.dump('test', 'Setting the forecolor to black should remove both the style and the span');
document.execCommand('undo', false, null);
Markup.dump('test', 'Undo should make "test" blue again');

Powered by Google App Engine
This is Rietveld 408576698