third_party/WebKit/Source/core/dom/Element.cpp - Issue 2800723002: Ensure we never remove the style attribute when syncing it from CSSOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2800723002: Ensure we never remove the style attribute when syncing it from CSSOM. (Closed)

Patch Set: Rebaseline Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 4048627057cfba89fd7ef6947df9c88e11af6486..a5f1d219583146dcca60e408fa7c08fd321eedd3 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -4015,8 +4015,7 @@ void Element::SynchronizeStyleAttributeInternal() const {

GetElementData()->style_attribute_is_dirty_ = false;

const StylePropertySet* inline_style = this->InlineStyle();

const_cast<Element*>(this)->SetSynchronizedLazyAttribute(

- styleAttr,

- inline_style ? AtomicString(inline_style->AsText()) : g_null_atom);

+ styleAttr, AtomicString(inline_style ? inline_style->AsText() : ""));

esprehn 2017/04/18 01:57:01 inline_style ? AtomicString(inline_style->AsText()

}

CSSStyleDeclaration* Element::style() {

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/external/wpt/editing/run/underline-expected.txt ('k') | no next file » | no next file with comments »