[Payments] Move parsing the PaymentMethodData to "core"

components/payments/content/payment_request_spec.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_request_spec.h"
 
 #include <utility>
 
 #include "base/logging.h"
+#include "components/payments/core/payment_method_data.h"
+#include "components/payments/core/payment_request_data_util.h"
 
 namespace payments {
 
+namespace {
+
+// Returns the card network name associated with a given BasicCardNetwork. Names
+// are inspired by https://www.w3.org/Payments/card-network-ids.
+std::string GetBasicCardNetworkName(const mojom::BasicCardNetwork& network) {
+  switch (network) {
+    case mojom::BasicCardNetwork::AMEX:
+      return "amex";

[please use gerrit instead, 2017/04/05 19:29:25]

Can we define an enum in components/payments/core/ and use that instead of
strings?

[Mathieu, 2017/04/05 20:28:33]

There is still a moment where we need to convert to string to pass back to the
merchant in the PaymentResponse (say supported_methods = ["visa"]). One way or
another we will need a function like this, I believe.

[Mathieu, 2017/04/05 20:32:44]

Actually this string here doesn't make its way to the PaymentResponse. But, it
eventually gets compared as part of autofill_data_util [1] with types in
CreditCard, and so forth. We could convert to enums some of the way, but
eventually we will need to go to std::string for the PaymentResponse.


[1]
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofil...

+    case mojom::BasicCardNetwork::DINERS:
+      return "diners";
+    case mojom::BasicCardNetwork::DISCOVER:
+      return "discover";
+    case mojom::BasicCardNetwork::JCB:
+      return "jcb";
+    case mojom::BasicCardNetwork::MASTERCARD:
+      return "mastercard";
+    case mojom::BasicCardNetwork::MIR:
+      return "mir";
+    case mojom::BasicCardNetwork::UNIONPAY:
+      return "unionpay";
+    case mojom::BasicCardNetwork::VISA:
+      return "visa";
+  }
+}
+
+}  // namespace
+
 const char kBasicCardMethodName[] = "basic-card";
 
 PaymentRequestSpec::PaymentRequestSpec(
     mojom::PaymentOptionsPtr options,
     mojom::PaymentDetailsPtr details,
     std::vector<mojom::PaymentMethodDataPtr> method_data,
     Observer* observer,
     const std::string& app_locale)
     : options_(std::move(options)),
       details_(std::move(details)),
@@ skipping 67 matching lines @@
 
 std::string PaymentRequestSpec::GetFormattedCurrencyCode() {
   CurrencyFormatter* formatter = GetOrCreateCurrencyFormatter(
       details_->total->amount->currency,
       details_->total->amount->currency_system, app_locale_);
 
   return formatter->formatted_currency_code();
 }
 
 void PaymentRequestSpec::PopulateValidatedMethodData(
-    const std::vector<mojom::PaymentMethodDataPtr>& method_data) {
-  if (method_data.empty()) {
+    const std::vector<mojom::PaymentMethodDataPtr>& method_data_mojom) {
+  if (method_data_mojom.empty()) {
     LOG(ERROR) << "Invalid payment methods or data";
     NotifyOnInvalidSpecProvided();
     return;
   }
 
-  std::set<std::string> card_networks{"amex",     "diners",     "discover",
-                                      "jcb",      "mastercard", "mir",
-                                      "unionpay", "visa"};
-  for (const mojom::PaymentMethodDataPtr& method_data_entry : method_data) {
-    std::vector<std::string> supported_methods =
-        method_data_entry->supported_methods;
-    if (supported_methods.empty()) {
-      LOG(ERROR) << "Invalid payment methods or data";
-      NotifyOnInvalidSpecProvided();
-      return;
+  std::vector<PaymentMethodData> method_data_vector;
+  method_data_vector.reserve(method_data_mojom.size());
+  for (const mojom::PaymentMethodDataPtr& method_data_entry :
+       method_data_mojom) {
+    PaymentMethodData method_data;
+    method_data.supported_methods = method_data_entry->supported_methods;
+    // Transfer the supported basic card networks.
+    std::vector<std::string> supported_networks;
+    for (const mojom::BasicCardNetwork& network :
+         method_data_entry->supported_networks) {
+      supported_networks.push_back(GetBasicCardNetworkName(network));
     }
+    method_data.supported_networks = std::move(supported_networks);

[please use gerrit instead, 2017/04/05 19:29:25]

What happens when moving a vector of strings, exactly?

[Mathieu, 2017/04/05 20:28:33]

I'm moving this local variable to avoid a copy, essentially, since we know that
beyond this line, |supported_networks| is not needed.

 
-    for (const std::string& method : supported_methods) {
-      if (method.empty())
-        continue;
-
-      // If a card network is specified right in "supportedMethods", add it.
-      auto card_it = card_networks.find(method);
-      if (card_it != card_networks.end()) {
-        supported_card_networks_.push_back(method);
-        // |method| removed from |card_networks| so that it is not doubly added
-        // to |supported_card_networks_| if "basic-card" is specified with no
-        // supported networks.
-        card_networks.erase(card_it);
-      } else if (method == kBasicCardMethodName) {
-        // For the "basic-card" method, check "supportedNetworks".
-        if (method_data_entry->supported_networks.empty()) {
-          // Empty |supported_networks| means all networks are supported.
-          supported_card_networks_.insert(supported_card_networks_.end(),
-                                          card_networks.begin(),
-                                          card_networks.end());
-          basic_card_specified_networks_.insert(card_networks.begin(),
-                                                card_networks.end());
-          // Clear the set so that no further networks are added to
-          // |supported_card_networks_|.
-          card_networks.clear();
-        } else {
-          // The merchant has specified a few basic card supported networks. Use
-          // the mapping to transform to known basic-card types.
-          using mojom::BasicCardNetwork;
-          std::unordered_map<BasicCardNetwork, std::string> networks = {
-              {BasicCardNetwork::AMEX, "amex"},
-              {BasicCardNetwork::DINERS, "diners"},
-              {BasicCardNetwork::DISCOVER, "discover"},
-              {BasicCardNetwork::JCB, "jcb"},
-              {BasicCardNetwork::MASTERCARD, "mastercard"},
-              {BasicCardNetwork::MIR, "mir"},
-              {BasicCardNetwork::UNIONPAY, "unionpay"},
-              {BasicCardNetwork::VISA, "visa"}};
-          for (const BasicCardNetwork& supported_network :
-               method_data_entry->supported_networks) {
-            // Make sure that the network was not already added to
-            // |supported_card_networks_|.
-            auto card_it = card_networks.find(networks[supported_network]);
-            if (card_it != card_networks.end()) {
-              supported_card_networks_.push_back(networks[supported_network]);
-              basic_card_specified_networks_.insert(
-                  networks[supported_network]);
-              card_networks.erase(card_it);
-            }
-          }
-        }
-      }
-    }
+    // TODO(crbug.com/708603): Add browser-side support for
+    // |method_data.supported_types|.
+    method_data_vector.push_back(std::move(method_data));
   }
 
+  if (!data_util::ParseBasicCardSupportedNetworks(
+          method_data_vector, &supported_card_networks_,
+          &basic_card_specified_networks_)) {
+    LOG(ERROR) << "Invalid payment methods or data";
+    NotifyOnInvalidSpecProvided();
+    return;
+  }
   supported_card_networks_set_.insert(supported_card_networks_.begin(),
                                       supported_card_networks_.end());
 }
 
 void PaymentRequestSpec::UpdateSelectedShippingOption() {
   if (!request_shipping())
     return;
 
   // As per the spec, the selected shipping option should initially be the last
   // one in the array that has its selected field set to true.
@@ skipping 26 matching lines @@
     const std::string& currency_system,
     const std::string& locale_name) {
   if (!currency_formatter_) {
     currency_formatter_.reset(
         new CurrencyFormatter(currency_code, currency_system, locale_name));
   }
   return currency_formatter_.get();
 }
 
 }  // namespace payments