Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3854)

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler.h

Issue 2800683008: Sync confirmation: change "Settings" link to checkbox (Closed)
Patch Set: tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/sync_confirmation_handler.h
diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_handler.h b/chrome/browser/ui/webui/signin/sync_confirmation_handler.h
index 8953681eb80fb6a5796b90111bc26bb483e66101..7de63347d1887670e87a42773a9b55d4a43a2395 100644
--- a/chrome/browser/ui/webui/signin/sync_confirmation_handler.h
+++ b/chrome/browser/ui/webui/signin/sync_confirmation_handler.h
@@ -36,7 +36,8 @@ class SyncConfirmationHandler : public content::WebUIMessageHandler,
protected:
// Handles "confirm" message from the page. No arguments.
// This message is sent when the user confirms that they want complete sign in
- // with default sync settings.
+ // with default sync settings. Passed a single boolean argument: whether to
+ // configure settings before signing in.
virtual void HandleConfirm(const base::ListValue* args);
// Handles "undo" message from the page. No arguments.
@@ -44,12 +45,6 @@ class SyncConfirmationHandler : public content::WebUIMessageHandler,
// dialog, which aborts signin and prevents sync from starting.
virtual void HandleUndo(const base::ListValue* args);
- // Handles "goToSettings" message from the page. No arguments.
- // This message is sent when the user clicks on the "Settings" link in the
- // sync confirmation dialog, which completes sign in but takes the user to the
- // sync settings page for configuration before starting sync.
- virtual void HandleGoToSettings(const base::ListValue* args);
-
// Handles the web ui message sent when the html content is done being laid
// out and it's time to resize the native view hosting it to fit. |args| is
// a single integer value for the height the native view should resize to.
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.cc ('k') | chrome/browser/ui/webui/signin/sync_confirmation_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698