Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3731)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 2800683008: Sync confirmation: change "Settings" link to checkbox (Closed)
Patch Set: tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index ba493b5ed7afafca41f1d92c4385aa18ec15b25e..5d331b469173317effebacc2ce600730c39053c1 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -428,7 +428,7 @@ void OneClickSigninSyncStarter::OnSyncConfirmationUIClosed(
case LoginUIService::CONFIGURE_SYNC_FIRST:
base::RecordAction(
base::UserMetricsAction("Signin_Signin_WithAdvancedSyncSettings"));
- chrome::ShowSettingsSubPage(browser_, chrome::kSyncSetupSubPage);
+ ShowSyncSetupSettingsSubpage();
break;
case LoginUIService::SYNC_WITH_DEFAULT_SETTINGS: {
base::RecordAction(
@@ -573,6 +573,10 @@ Browser* OneClickSigninSyncStarter::EnsureBrowser(Browser* browser,
return browser;
}
+void OneClickSigninSyncStarter::ShowSyncSetupSettingsSubpage() {
+ chrome::ShowSettingsSubPage(browser_, chrome::kSyncSetupSubPage);
+}
+
void OneClickSigninSyncStarter::ShowSettingsPage(bool configure_sync) {
// Give the user a chance to configure things. We don't clear the
// ProfileSyncService::setup_in_progress flag because we don't want sync
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.h ('k') | chrome/browser/ui/webui/signin/sync_confirmation_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698