Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: ios/chrome/browser/reading_list/offline_url_utils.h

Issue 2800673002: [iOS Reading List] Only allow offline URL when the offline file exists. (Closed)
Patch Set: Update comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/offline_url_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/reading_list/offline_url_utils.h
diff --git a/ios/chrome/browser/reading_list/offline_url_utils.h b/ios/chrome/browser/reading_list/offline_url_utils.h
index d7af133b49e0e8f24e29d7bcecd2c71dbe3d10f7..34caa5d2af288692cadfec965f4c6ce7d9e598d4 100644
--- a/ios/chrome/browser/reading_list/offline_url_utils.h
+++ b/ios/chrome/browser/reading_list/offline_url_utils.h
@@ -11,23 +11,26 @@
#include "base/strings/string16.h"
#include "url/gurl.h"
+class ReadingListModel;
+
namespace reading_list {
// The distilled URL chrome://offline/... that will load the file at |path|.
// |entry_url| is the URL of the ReadingListEntry.
// |virtual_url| is the URL to display in the omnibox. This can be different
-// from |entry_url| is the distillation was done after a redirection.
-// |entry_url| and |virtual_url| are optionnal.
+// from |entry_url| if the distillation was done after a redirection.
+// |distilled_path|, |entry_url| and |virtual_url| are required and must not be
+// empty or invalid.
GURL OfflineURLForPath(const base::FilePath& distilled_path,
const GURL& entry_url,
const GURL& virtual_url);
// If |offline_url| has a "entryURL" query params that is a URL, returns it.
-// If not, return |offline_url|
+// If not, return GURL::EmptyURL().
GURL EntryURLForOfflineURL(const GURL& offline_url);
// If |offline_url| has a "virtualURL" query params that is a URL, returns it.
-// If not, return |EntryURLForOfflineURL(|offline_url|)|
+// If not, return GURL::EmptyURL().
GURL VirtualURLForOfflineURL(const GURL& offline_url);
// The file URL pointing to the local file to load to display |distilled_url|.
@@ -41,6 +44,12 @@ GURL FileURLForDistilledURL(const GURL& distilled_url,
// Returns whether the URL points to a chrome offline URL.
bool IsOfflineURL(const GURL& url);
+// Returns whether the URL points to a valid chrome offline URL that can be
+// displayed by a |OfflinePageNativeContent|.
+// Returns false if |model| is null, not loaded or does not contain entry
+// pointed by |url|.
+bool IsOfflineURLValid(const GURL& url, ReadingListModel* model);
+
} // namespace reading_list
#endif // IOS_CHROME_BROWSER_READING_LIST_OFFLINE_URL_UTILS_H_
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/offline_url_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698