Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: components/policy/core/common/cloud/external_policy_data_fetcher.cc

Issue 2800653002: Network traffic annotation added to common/cloud. (Closed)
Patch Set: Annotation updated. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/external_policy_data_fetcher.cc
diff --git a/components/policy/core/common/cloud/external_policy_data_fetcher.cc b/components/policy/core/common/cloud/external_policy_data_fetcher.cc
index 70f6e5e9ab3dfd67d5044639cebd153d718a8b9e..6209493110eb13ade89a291d4b7995c13dabffae 100644
--- a/components/policy/core/common/cloud/external_policy_data_fetcher.cc
+++ b/components/policy/core/common/cloud/external_policy_data_fetcher.cc
@@ -17,6 +17,7 @@
#include "components/data_use_measurement/core/data_use_user_data.h"
#include "net/base/load_flags.h"
#include "net/base/net_errors.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_context_getter.h"
#include "net/url_request/url_request_status.h"
@@ -177,8 +178,32 @@ ExternalPolicyDataFetcherBackend::CreateFrontend(
void ExternalPolicyDataFetcherBackend::StartJob(
ExternalPolicyDataFetcher::Job* job) {
DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
- std::unique_ptr<net::URLFetcher> owned_fetcher = net::URLFetcher::Create(
- ++last_fetch_id_, job->url, net::URLFetcher::GET, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("external_policy_fetcher", R"(
+ semantics {
+ sender: "Cloud Policy"
+ description:
+ "Used to fetch policy for extensions, policy-controlled wallpaper, "
+ "and custom terms of service."
+ trigger:
+ "Periodically loaded when a managed user is signed in to Chrome."
+ data:
+ "This request does not send any data. It loads external resources "
+ "by a unique URL provided by the admin."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ cookies_allowed: false
+ setting:
+ "This feature cannot be controlled by Chrome settings, but users "
+ "can sign out of Chrome to disable it."
+ policy_exception_justification:
+ "Not implemented, considered not useful. This request is part of "
+ "the policy fetcher itself."
+ })");
+ std::unique_ptr<net::URLFetcher> owned_fetcher =
+ net::URLFetcher::Create(++last_fetch_id_, job->url, net::URLFetcher::GET,
+ this, traffic_annotation);
net::URLFetcher* fetcher = owned_fetcher.get();
data_use_measurement::DataUseUserData::AttachToFetcher(
fetcher, data_use_measurement::DataUseUserData::POLICY);

Powered by Google App Engine
This is Rietveld 408576698