Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: components/policy/core/common/cloud/user_info_fetcher.cc

Issue 2800653002: Network traffic annotation added to common/cloud. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/user_info_fetcher.cc
diff --git a/components/policy/core/common/cloud/user_info_fetcher.cc b/components/policy/core/common/cloud/user_info_fetcher.cc
index bf5c78cc03402ab74656ad032c519a15a5ef2372..da40817af639389ef0e7c32bebcad1595f50f18c 100644
--- a/components/policy/core/common/cloud/user_info_fetcher.cc
+++ b/components/policy/core/common/cloud/user_info_fetcher.cc
@@ -13,6 +13,7 @@
#include "google_apis/gaia/google_service_auth_error.h"
#include "net/base/load_flags.h"
#include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_status.h"
#include "url/gurl.h"
@@ -41,10 +42,31 @@ UserInfoFetcher::~UserInfoFetcher() {
}
void UserInfoFetcher::Start(const std::string& access_token) {
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("...", R"(
+ semantics {
+ sender: "..."
pastarmovj 2017/04/07 09:58:46 Cloud Policy
Ramin Halavati 2017/04/19 05:21:58 Done.
+ description: "..."
Andrew T Wilson (Slow) 2017/04/18 12:01:32 Calls to the Google Account service to check if th
Ramin Halavati 2017/04/19 05:21:58 Done.
+ trigger: "..."
Andrew T Wilson (Slow) 2017/04/18 12:01:32 User signing in to Chrome.
Ramin Halavati 2017/04/19 05:21:58 Done.
+ data: "..."
Andrew T Wilson (Slow) 2017/04/18 12:01:32 Information about the user (specifically whether t
Ramin Halavati 2017/04/19 05:21:58 Done.
+ destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
pastarmovj 2017/04/07 09:58:46 GOOGLE_OWNED_SERVICE
Ramin Halavati 2017/04/19 05:21:58 Done.
+ }
+ policy {
+ cookies_allowed: false/true
pastarmovj 2017/04/07 09:58:46 true?
Andrew T Wilson (Slow) 2017/04/18 12:01:32 true
Ramin Halavati 2017/04/19 05:21:58 SAVE and SEND seem to be disabled in load flags. A
Andrew T Wilson (Slow) 2017/04/25 13:48:01 Not intentionally. So feel free to mark this as fa
Ramin Halavati 2017/04/26 05:28:06 Done.
+ cookies_store: "..."
Andrew T Wilson (Slow) 2017/04/18 12:01:32 system
Ramin Halavati 2017/04/19 05:21:58 Done.
+ setting: "..."
Andrew T Wilson (Slow) 2017/04/18 12:01:32 none
Ramin Halavati 2017/04/19 05:21:58 Done.
+ chrome_policy {
+ [POLICY_NAME] {
Andrew T Wilson (Slow) 2017/04/18 12:01:32 SigninAllowed
Ramin Halavati 2017/04/19 05:21:58 Done.
+ policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
Andrew T Wilson (Slow) 2017/04/18 12:01:32 MANDATORY
Ramin Halavati 2017/04/19 05:21:58 Done.
+ [POLICY_NAME]: ... //(value to disable it)
Andrew T Wilson (Slow) 2017/04/18 12:01:32 SigninAllowed: false
Ramin Halavati 2017/04/19 05:21:58 Done.
+ }
+ }
+ policy_exception_justification: "..."
pastarmovj 2017/04/07 09:58:46 The request is part of the policy fetcher itself.
Ramin Halavati 2017/04/19 05:21:58 Done.
+ })");
// Create a URLFetcher and start it.
url_fetcher_ =
net::URLFetcher::Create(0, GaiaUrls::GetInstance()->oauth_user_info_url(),
- net::URLFetcher::GET, this);
+ net::URLFetcher::GET, this, traffic_annotation);
data_use_measurement::DataUseUserData::AttachToFetcher(
url_fetcher_.get(), data_use_measurement::DataUseUserData::POLICY);
url_fetcher_->SetRequestContext(context_);

Powered by Google App Engine
This is Rietveld 408576698